Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): remove @chromatic-com/storybook dep as it is unused #2945

Merged
merged 1 commit into from
Oct 7, 2024
Merged

chore(deps): remove @chromatic-com/storybook dep as it is unused #2945

merged 1 commit into from
Oct 7, 2024

Conversation

ByronDWall
Copy link
Contributor

Summary

We found that using chromatic/storybook for visual/e2e testing would not give us enough of a benefit over percy to switch, so we dont need this dep.

@ByronDWall ByronDWall self-assigned this Oct 7, 2024
@ByronDWall ByronDWall requested a review from a team as a code owner October 7, 2024 15:16
@ByronDWall ByronDWall requested review from stephsprinkle, jaikamat, ddouglasz, tylermorrisford and misama-ct and removed request for a team October 7, 2024 15:16
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 634a33d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 3:41pm

@ByronDWall ByronDWall mentioned this pull request Oct 7, 2024
Closed
1 task
@ByronDWall ByronDWall merged commit a453440 into main Oct 7, 2024
5 checks passed
@ByronDWall ByronDWall deleted the bw/fld-remove-chromatic-dep branch October 7, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaikamat jaikamat jaikamat approved these changes

@tylermorrisford tylermorrisford tylermorrisford approved these changes

@stephsprinkle stephsprinkle Awaiting requested review from stephsprinkle stephsprinkle is a code owner automatically assigned from commercetools/first-contact-team-fe

@ddouglasz ddouglasz Awaiting requested review from ddouglasz ddouglasz is a code owner automatically assigned from commercetools/first-contact-team-fe

@misama-ct misama-ct Awaiting requested review from misama-ct misama-ct is a code owner automatically assigned from commercetools/first-contact-team-fe

Assignees

@ByronDWall ByronDWall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ByronDWall @jaikamat @tylermorrisford