-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ReactSelectAsyncProps): improve SearchSelectInput
, SearchSelectField
and AsyncSelectInput
types
#2946
Open
ragafus
wants to merge
3
commits into
main
Choose a base branch
from
rg-react-select-async-props
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragafus
requested review from
stephsprinkle,
jaikamat,
ddouglasz,
tylermorrisford,
ByronDWall and
misama-ct
and removed request for
a team
October 7, 2024 15:43
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 77f2d03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 98 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ragafus
removed request for
stephsprinkle,
jaikamat,
ddouglasz,
tylermorrisford,
ByronDWall and
misama-ct
October 7, 2024 15:43
ragafus
force-pushed
the
rg-react-select-async-props
branch
from
October 7, 2024 16:20
42e5f41
to
c3673d2
Compare
ragafus
force-pushed
the
rg-react-select-async-props
branch
from
October 14, 2024 07:58
c3673d2
to
f24a37c
Compare
ragafus
changed the title
refactor: improve types
refactor(ReactSelectAsyncProps): improve Oct 14, 2024
SearchSelectInput
, SearchSelectField
and AsyncSelectInput
types
ragafus
requested review from
a team,
stephsprinkle,
jaikamat,
ddouglasz,
tylermorrisford,
ByronDWall and
misama-ct
and removed request for
a team
October 14, 2024 14:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
THis PR improves SearchSelectInput, SearchSelectField and AsyncSelectInput types by extending the generics of AsyncSelect from react-select/async.
Fixes #2963
Description