Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - status for cancelled build #547

Closed
pierrotsmnrd opened this issue Aug 25, 2023 · 5 comments · Fixed by #747
Closed

[ENH] - status for cancelled build #547

pierrotsmnrd opened this issue Aug 25, 2023 · 5 comments · Fixed by #747

Comments

@pierrotsmnrd
Copy link
Contributor

Feature description

Once PR #531 is merged, we'll have the possibility to cancel builds.
In the current state of this feature, a cancelled build has a "Failed" status.

Implementing a clear "Cancelled" status would be clearer for the users.
Implementing this would imply adding an Alembic migration

Value and/or benefit

  • Clearer build status for the users

Anything else?

No response

@kcpevey
Copy link
Contributor

kcpevey commented Aug 28, 2023

@pierrotsmnrd it looks like #531 implements the backend for cancelling builds and this issue is focussed on the front end. Is that correct?

image

Thinking through the UX:

How do I know a build is cancelled?:
The "CANCELLED" status should just be similar to the Available/Failed/Active field in the above image. Is anything else missing for that to work?

How do I cancel a build?:
We need some design work here to decide how and where to present this to users.

  • Will it have a popup confirmation modal?
  • After clicking to cancel a build, will the UI element (e.g. button) change from "Cancel" to "Cancelling" or something to indicate that its working?

@costrouc
Copy link
Member

@pierrotsmnrd it looks like #531 implements the backend for cancelling builds and this issue is focussed on the front end. Is that correct?

@kcpevey this issue is focusing on the issue that currently conda-store-server's schema for BuildStatus only knows of queued, building, failed, completed. We're adding a new status canceled which signifies that the build did not fail but was explicitly canceled.

There are several places in conda-store-server where build status implies which actions are allowable and should be taken and this issue/PR will need to address that.

@nkaretnikov
Copy link
Contributor

See #531 (comment)

@nkaretnikov
Copy link
Contributor

Status update: this is blocked until #531 lands

@pavithraes
Copy link
Member

#531 is merged, this issue is now unblocked :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants