Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #476 : delete dangling build artifacts before migration #477

Merged
merged 1 commit into from
May 2, 2023

Conversation

pierrotsmnrd
Copy link
Contributor

Fix #476 : Delete dangling build artifacts before migration.

Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@costrouc
Copy link
Member

costrouc commented May 2, 2023

@pierrotsmnrd going forward I was wondering what adjustments would be needed in the orm model?

@pierrotsmnrd
Copy link
Contributor Author

@costrouc my understanding is that nothing else is necessary.

This line ensures the on-delete cascade from build to build_artifacts and was added 2 years ago.

So :

  • Either there's something we haven't spot yet in the codebase that leads to dangling build_artifacts (but what ?)
  • Or the case we encountered is the result of an old install of conda-store, where builds has been deleted before the on-delete cascade was added. Considering this identified case is using an old Postgres 11.14, this hypothesis could make sense. Or maybe they tinkered with their data and we don't know.

@costrouc costrouc merged commit ac430b3 into main May 2, 2023
@costrouc costrouc deleted the fix476-migration branch May 2, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alembic migration failing in some edge case
2 participants