-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dcmcand optimize docker files #625
Conversation
…imize-docker-files
✅ Deploy Preview for kaleidoscopic-dango-0cf31d canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat I love some image optimisation 🎉 It seems now that we are duplicating some bits in the build_docker_image.yaml
and the release.yaml
to keep these aligned and reduce duplication. Shall we move these tidbits into a reusable action and call it from the workflows instead?
I think that makes sense. |
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
FYI: integration test failure is unrelated, I'm investigating: #632 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good so will go ahead and merge and we can see how these changes look with the release candidate tomorrow 🤞🏽
Thanks @dcmcand
Follow on to #621 that should be merged before this is reviewed
Description
This PR optimizes the Docker files for the conda-store and conda-store-server images.
Currently the conda-store image is 1.54GB. This PR reduces that to 890MB by using multistage builds. This is a reduction of 43%.
The current conda-store-server image is 1.96GB. This PR reduces that to 1.24GB, a reduction of 37%.
ChatGPT
Smaller Docker images offer faster container deployment, reduced storage and bandwidth costs, and enhanced security by minimizing potential attack surfaces.
This pull request:
Pull request checklist
Additional information