Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place a bound on docker-py #689

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

nkaretnikov
Copy link
Contributor

@nkaretnikov nkaretnikov commented Dec 9, 2023

A new version of docker-py was released and it now causes issues with docker-compose because the latter doesn't work with the new version. This PR adds a bound to make sure the versions are compatible.

New version that causes problems:

docker-py                             7.0.0  pyhd8ed1ab_0        conda-forge/noarch

Old version that works:

docker-py                             6.1.3  pyhd8ed1ab_0        conda-forge/noarch

This error was printed on CI during Tests / integration-test conda-store-server (pull_request):

Traceback (most recent call last):
  File "/usr/share/miniconda3/envs/test/bin/docker-compose", line 11, in <module>
    sys.exit(main())
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/main.py", line 81, in main
    command_func()
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/main.py", line 200, in perform_command
    project = project_from_options('.', options)
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/command.py", line 60, in project_from_options
    return get_project(
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/command.py", line 152, in get_project
    client = get_client(
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/docker_client.py", line 41, in get_client
    client = docker_client(
  File "/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/compose/cli/docker_client.py", line 124, in docker_client
    kwargs = kwargs_from_env(environment=environment, ssl_version=tls_version)
TypeError: kwargs_from_env() got an unexpected keyword argument 'ssl_version'
Error: Process completed with exit code 1.

Copy link

netlify bot commented Dec 9, 2023

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
🔨 Latest commit 39b8bf3
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/6574fb77d209700008c5e9da

@nkaretnikov

This comment was marked as duplicate.

@nkaretnikov
Copy link
Contributor Author

This is ready for review.

Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@trallard trallard merged commit 32ce193 into conda-incubator:main Dec 12, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies 📦 Issues related to conda-store dependencies status: merge ready 🚀
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants