Make conda_flags configurable #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-store canceled.
|
nkaretnikov
force-pushed
the
customizable-conda-flags
branch
from
95593e7
to
f657ad8
Compare
nkaretnikov
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
conda_flagsparameter in https://github.com/conda-incubator/conda-store/blob/2024.3.1/conda-store-server/conda_store_server/action/generate_lockfile.py#L20 but this is not configurable.This PR includes changes to have the
conda_flagsparameter configurable from the config py script.Description
We are using conda-store within nebari in one of our projects. We have a reason why we don't need strict channel priority while building the environments. The default is still
--strict-channel-priorityto be backwards compatible, but it makes the option to the user to configure different conda flags e.g.--no-channel-priority.Pull request checklist
How to test
Add e.g.
c.CondaStore.conda_flags = "--no-channel-priority"in the config py script.