Resolve kustomize warnings #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bases are deprecated and should be replaced by resources. Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
it should be safe to replace patchesJson6902 with patches now. Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
no changes just removing empty indentation. Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
the "kustomize edit fix" complains about these missing. Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
ldoktor
force-pushed
the
kustomize-warnings
branch
from
76c098e
to
429b4b7
Compare
wainersm
approved these changes
Apr 23, 2024
|
We had some issues in the past that some of our code wasn't compatible with the new kustomize format, so a couple of us made this change before and had to back it out (e.g. #1023), but maybe we have bumped versions enough for it to work now as the libvirt e2e tests are passing? I'll try and test it out with ibmcloud today to see if that shows any issues... |
|
It looks to work on IBM Cloud so far, but I'm still hitting kustomize warnings: May switching those were the blocking issues we had before? |
stevenhorsman
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
I think there are some other warnings still kicking around, but it's still an improvement to remove these. Thanks @ldoktor!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While setting-up my libvirt+kcli I noticed a few warnings from kustomize. I used
kustomize edit fixto learn what to replace and then addressed all places usingsed. Note the behaviour should not change but I have only tested the default libvirt e2e setup with kcli.