Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/libvirt: small improvements #1803

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

beraldoleal
Copy link
Member

Some small improvements I found when following the latest docs.

This document focuses exclusively on creating an end-to-end environment;
there are no other sections. Removing it will simplify the table of
contents.

Signed-off-by: Beraldo Leal <bleal@redhat.com>
This code block is simply copied and pasted from the script, which will
make it difficult to keep updated if we modify the script later. It also
confuses users because we provide a helper script. Let's just remove it
and add a warning note instead.

Signed-off-by: Beraldo Leal <bleal@redhat.com>
Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @beraldoleal

Copy link

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huoqifeng huoqifeng merged commit 6c85448 into confidential-containers:main Apr 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants