-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provisioner: Add support to fetch kbs nodeport service ip #1812
provisioner: Add support to fetch kbs nodeport service ip #1812
Conversation
Steps to test this PR:
Check peerpod cm
|
d5eae02
to
b7d8995
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kartikjoshi21 I added a comment...
b7d8995
to
6ab9d02
Compare
6ab9d02
to
dd5d7ca
Compare
@mkulke @huoqifeng updated code and logs, Thanks. |
Fixes: confidential-containers#1809 Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
dd5d7ca
to
33f342c
Compare
Looks some CI errors? |
Functionality wise, this has worked for me. |
It was unrelated, retriggered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @kartikjoshi21
Fixes: #1809