libvirt: update script to config libvirt on RHEL. #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huoqifeng
reviewed
Apr 26, 2024
wyuany
force-pushed
the
config-libvirt-rhel
branch
from
d8f6c7b
to
e1edb12
Compare
beraldoleal
previously requested changes
Apr 26, 2024
There was a problem hiding this comment.
Hi @wyuany this is welcome, thanks! LGTM, except it shows 3 commits.
Do you mind rebasing/squashing them?
stevenhorsman
approved these changes
Apr 26, 2024
wyuany
force-pushed
the
config-libvirt-rhel
branch
from
e1edb12
to
f2d5ad1
Compare
Update script to config libvirt not only work with Ubuntu but also RHEL Fixes: confidential-containers#1821 Signed-off-by: Yuan Yuan Wang <wyuany@cn.ibm.com>
wyuany
force-pushed
the
config-libvirt-rhel
branch
from
f2d5ad1
to
7249de0
Compare
huoqifeng
dismissed
beraldoleal’s stale review
Review comments addressed already, thanks! Beraldo, To merge the PR, I have to dismiss the rejection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update script to config libvirt not only work with Ubuntu but also RHEL
Fixes: #1821