Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibmcloud: revise ibmcloud README #1914

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

genjuro214
Copy link
Contributor

I followed the guide to Deploy the Confidential-containers operator on a self-managed cluster in IBM Cloud VPC. However, it doesn't work as expected. I try to fix 2 problems:

failed to create an instance : Expected only one oneOf fields to be set: got 0 and the response is {

"code": "validation_failed_oneof",
                "message": "Expected only one oneOf fields to be set: got 0",
                "target": {
                    "name": "InstancePrototype",
                    "type": "field"
                }

"message": "InstanceByImage is invalid: Expected only one oneOf fields to be set: got 0",

- fix the default VPC service url
- add missing settings in selfmanaged_cluster.properties

Signed-off-by: Lei Li <genjuro214@gmail.com>
Signed-off-by: Lei Li <cdlleili@cn.ibm.com>
@stevenhorsman stevenhorsman added the test_e2e_libvirt Run Libvirt e2e tests label Jul 9, 2024
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine. Just to note that these won't fix the issues I'm seeing with #1882 as I've been providing the extra properties in self_managed.properties and the VpcServiceUrls is overwritten in our e2e test code to the correct value.

Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@genjuro214 genjuro214 merged commit b56c13a into confidential-containers:main Jul 10, 2024
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test_e2e_libvirt Run Libvirt e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants