-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Release doc updates #1917
doc: Release doc updates #1917
Conversation
docs/Release-Process.md
Outdated
```bash | ||
./hack/release-helper.sh v0.8.0-alpha.1 | ||
./hack/release-helper.sh go_tag v0.8.0-alpha.1 upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @stevenhorsman !
I missed the PR that introduced the release-helper.sh
. Great script!
One minor fix here, the command is go-tag
rather than go_tag
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else looks good. I will give my approval upfront ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, I started with go_tag
and then renamed it, but obviously missed one. Thanks for spotting.
Update the release process with some optimizations found during the release process: - Merge the pre-release operator version bump and go mod update into the same PR to save a round of reviews - Update the release-helper to enable the upstream branch to be passed in rather than it being hard coded during go-tag action - Add an extra command to the release-helper to help with updating the CAA image tags in the install kustomization.yaml files for the various cloud providers, without impacting the file layout Signed-off-by: stevenhorsman <steven@uk.ibm.com>
3aa93fb
to
7786ac5
Compare
[`quay.io/confidential-containers/cloud-api-adaptor`](https://quay.io/repository/confidential-containers/cloud-api-adaptor?tab=tags) | ||
to use in testing. | ||
To do this, we should update the `git.coco-operator.reference` value in [versions.yaml](../src/cloud-api-adaptor/versions.yaml) | ||
and create a commit for this and add the following changes as a second commit to the same PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the following changes
are you referring to all the changes mentioned in the next section ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, perhaps it's clear, but in the alpha1 I followed the instructions to create two separate PRs for this, but there is no dependency, so wanted to skip a review cycle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
90620bf
into
confidential-containers:main
Update the release process with some optimizations found during the release process: