auth: allow specifying auth.json for guest-pull #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkulke
force-pushed
the
mkulke/propagate-image-pull-auth
branch
6 times, most recently
from
bdad5f9
to
1604871
Compare
Kata introduced a flag to specify `image-registry-auth` which we can in guest pull. Since our agent-configuration is mostly static and we want to avoid brittle templating we provision the full kata-agent config from the CAA application like other config files. If an auth secret is present in a CAA deployment, CAA will embed it in the agent config and provision it to the guest. The static agent-configuration has been removed and the configuration is pointing to `/run/peerpod/agent-config.toml` now, since it is a resource that changes at runtime. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
mkulke
force-pushed
the
mkulke/propagate-image-pull-auth
branch
from
d98c3d4
to
3a1e07b
Compare
stevenhorsman
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
The code LGTM. I'm struggling to get it working locally, but I think it's just my environment that is going wrong as after I restarted from scratch I can't create any peer pods, so I'm happy to see this merged and then I'll test it out with the proper builds. Thanks for the work @mkulke!
bpradipt
reviewed
Jul 19, 2024
| Version = "0.0.0" | ||
| SrcAuthfilePath = "/root/containers/auth.json" | ||
| AgentConfigPath = "/run/peerpod/agent-config.toml" | ||
| AuthFilePath = "/run/peerpod/auth.json" |
There was a problem hiding this comment.
nit: Should these vars be prefixed with Def ?
There was a problem hiding this comment.
I opted to not call them DefaultSomething if they are hardcoded values that cannot be overridden.
|
I'm able to access the link that's failing in the CI. Looks like an infra issue |
|
Since it passed the e2e checks, there shouldn't be a regression. i'll merge, let's hope it'll work in automated tests 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kata introduced a flag to specify
image-registry-authwhich we can in guest pull. Since our agent-configuration is mostly static and we want to avoid brittle templating we provision the full kata-agent config from the CAA application like other config files.If an auth secret is present in a CAA deployment, CAA will embed it in the agent config and provision it to the guest. The static agent-configuration has been removed and the configuration is pointing to
/run/peerpod/agent-config.tomlnow, since it is a resource that changes at runtime.