process-user-data: Fix the assignment of config filenames #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with docker provider. Sample image for test - |
snir911
approved these changes
Jul 23, 2024
|
For reference the docker-provider e2e tests are working here for me except for the MTLS test that Pradipta has identified is due to the the use of the curl image and we don't think is a blocker. The podvm build failed in the CI e2e tests due to docker rate limits :( |
wainersm
reviewed
Jul 23, 2024
The config files were incorrectly assigned resulting in agent-config.toml not being created. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
bpradipt
force-pushed
the
fix-process-user-data
branch
from
7763928
to
2e313eb
Compare
stevenhorsman
approved these changes
Jul 23, 2024
|
I manually verified the PR on Azure. @wainersm verified on AWS. |
bpradipt
merged commit 39a5288
into
confidential-containers:main
28 of 29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config files were incorrectly assigned resulting in agent-config.toml not being created.