Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/e2e: fix TestLibvirtKbsKeyRelease skip #1963

Merged
merged 1 commit into from
Jul 30, 2024
Merged

tests/e2e: fix TestLibvirtKbsKeyRelease skip #1963

merged 1 commit into from
Jul 30, 2024

Conversation

lysliu
Copy link
Contributor

@lysliu lysliu commented Jul 30, 2024 •
edited
Loading

make align with test/e2e/main_test.go#L106

to fix the e2e testcase skipped

19:47:32  === RUN   TestLibvirtKbsKeyRelease
19:47:32      libvirt_test.go:109: Skipping kbs related test as kbs is not deployed
19:47:32  --- SKIP: TestLibvirtKbsKeyRelease (0.00s)
19:47:32  PASS

@lysliu lysliu changed the title fix TestLibvirtKbsKeyRelease skip tests/e2e: fix TestLibvirtKbsKeyRelease skip Jul 30, 2024
liudalibj
liudalibj approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liudalibj liudalibj requested a review from huoqifeng July 30, 2024 07:39
@lysliu
tests/e2e: fix TestLibvirtKbsKeyRelease skip
2bf41f8 
make align with test/e2e/main_test.go#L106

Signed-off-by: Yan Song Liu <lysliu@cn.ibm.com>
mkulke
mkulke approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@mkulke mkulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! i was just about to debug this

huoqifeng
huoqifeng approved these changes Jul 30, 2024
View reviewed changes
Copy link

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you! @lysliu

@huoqifeng huoqifeng merged commit c7c2a93 into confidential-containers:main Jul 30, 2024
20 checks passed
@lysliu lysliu deleted the fix-test-kbs branch July 31, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkulke mkulke mkulke approved these changes

@huoqifeng huoqifeng huoqifeng approved these changes

@liudalibj liudalibj liudalibj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysliu @mkulke @huoqifeng @liudalibj