libvirt-e2e: create auth.json file #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, that seems to fix the libvirt tests |
The auth.json file is not provisioned for the authenticated registry tests in the libvirt test suite. This adds the file and adjusts the kustomize configuration to use it. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
mkulke
force-pushed
the
mkulke/add-authjson-to-libvirt-tests
branch
from
d83123a
to
2461f78
Compare
bpradipt
reviewed
Jul 30, 2024
wainersm
reviewed
Jul 31, 2024
mkulke
force-pushed
the
mkulke/add-authjson-to-libvirt-tests
branch
from
2461f78
to
1624617
Compare
bpradipt
reviewed
Jul 31, 2024
Move more `log.` calls to `t.Log` to make e2e log output more readable Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
mkulke
force-pushed
the
mkulke/add-authjson-to-libvirt-tests
branch
from
1624617
to
a71257f
Compare
bpradipt
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auth.json file is not provisioned for the authenticated registry tests in the libvirt test suite. This adds the file and adjusts the kustomize configuration to use it.
drive-by fix: log formatting