Verifier: Refactor errors in cca module #326
Conversation
Fixes: confidential-containers#231 Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
| #[error("Failed to discover the verification endpoint details")] | ||
| VerificationEndpoint(), | ||
| #[error("anyhow error: {0}")] | ||
| Anyhow(#[from] anyhow::Error), |
There was a problem hiding this comment.
I am worried about this kind of error. Other types have determined semantics while this not. Could you try to classify the source of this error as one of the above and use map_err?
| @@ -80,13 +119,13 @@ impl Verifier for CCA { | |||
| expected_init_data_hash: &InitDataHash, | |||
| ) -> Result<TeeEvidenceParsedClaim> { | |||
| let ReportData::Value(expected_report_data) = expected_report_data else { | |||
| bail!("CCA verifier must provide report data field!"); | |||
| return Err(CCAError::ReportDataMissing.into()); | |||
There was a problem hiding this comment.
I notice that severval .into() are used in this function to convert Result<_, CCAError> to Result<_, anyhow::Error>.
One way to avoid this is to have an inner non-pub function cca_evaluate() -> Result<_, CCAError> to be wrapped by this evaluate(). In cca_evaluate() can delete all the .into()s. And in evaluate() just call cca_evaluate() to finish the error conversion.
Another way is to add another overall error type VerifierError under verifier. One enum is named CCA. And change the signature of evaluate(..)->anyhow::Result<TeeEvidenceParsedClaim> to evaluate(..)->Result<TeeEvidenceParsedClaim, VerifierError>. In this function different CCAErrors will finally be mapped into VerifierError::CCA.
It's up to you : )
| #[error("Serde Json Error")] | ||
| SerdeJson(#[from] serde_json::Error), |
There was a problem hiding this comment.
Could we add some extra information to this kind of error? I mean if this error is raised, the user will only see Serde Json Error and he will not know what is serded
There was a problem hiding this comment.
Adding error types with source as serde::json error and whole context for this.
Fixes: #231