Add governance proposal handler #37
Conversation
There was a problem hiding this comment.
Looks good. Gave some feedback to help finish it off.
Shall I make a tgrade-contract that registers for governance voting and will allow some admin to make governance proposals so you can do a full-stack test? (Something like the reflect contract, but a bit more powerful... you can use the reflect tests from wasmd as a template here)
There was a problem hiding this comment.
Good stuff. 98% satisfied and happy to see all the marshaling logic well covered with tests.
Just pointed out that 2 of the example JSON that is tested is not the format we return from the contract (it uses {} rather than "e30=").
If you update that (and optionally some of the other comments), I am happy to approve an merge.
|
I have addressed the issues. The last commit contains a wasmd upgrade as dependency that points to a branch. |
|
Nice! |
Resolves #6
After #41