Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update getting-started.md #1139

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

davidsneighbour
Copy link
Contributor

Overview

This pull request:

  • Fixes a bug
  • Adds a feature
  • Breaks backwards compatibility
  • Has tests that cover changes
  • Adds or fixes documentation

Summary

plenty of typos.

@greg-1-anderson
Copy link
Member

@Arhell Are docs changes in this repo automatically published to the website project in any way? I don't see anything in CI or the RoboFile that does it; I take it that it's all manual at the moment?

I can build some automation when I have time, just want to make sure that I'm not overlooking anything that's already there.

@Arhell
Copy link
Member

Arhell commented Feb 18, 2023

@Arhell Are docs changes in this repo automatically published to the website project in any way? I don't see anything in CI or the RoboFile that does it; I take it that it's all manual at the moment?

I can build some automation when I have time, just want to make sure that I'm not overlooking anything that's already there.

Yes, by hand, unfortunately

@greg-1-anderson
Copy link
Member

n.b. "isa" was not a typo, but a reference to the "isa" / "hasa" relationship in object oriented design. But "is a" will do as well.

@greg-1-anderson greg-1-anderson merged commit 68ae487 into consolidation:4.x Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants