-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate off from github.com/gogo/protobuf #6564
Comments
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Feb 17, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Feb 17, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/containerd
that referenced
this issue
Feb 17, 2022
This command will replace protobuf/plugin/fieldpath when we migrate off from gogo/protobuf. See containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Feb 18, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Feb 18, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/containerd
that referenced
this issue
Feb 21, 2022
This command will replace protobuf/plugin/fieldpath when we migrate off from gogo/protobuf. See containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
This was referenced Feb 21, 2022
kzys
added a commit
to kzys/hcsshim
that referenced
this issue
Feb 22, 2022
containerd is planning to migrate off from github.com/gogo/protobuf which will affect hcsshim. See containerd/containerd#6564 for the overall progress. Before that, this commit runs Protobuild in GitHub Actions to make sure all generated files are reproducible from .proto files. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
2 tasks
kzys
added a commit
to kzys/hcsshim
that referenced
this issue
Feb 28, 2022
containerd is planning to migrate off from github.com/gogo/protobuf which will affect hcsshim. See containerd/containerd#6564 for the overall progress. Before that, this commit runs Protobuild in GitHub Actions to make sure all generated files are reproducible from .proto files. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/hcsshim
that referenced
this issue
Feb 28, 2022
containerd is planning to migrate off from github.com/gogo/protobuf which will affect hcsshim. See containerd/containerd#6564 for the overall progress. Before that, this commit runs Protobuild in GitHub Actions to make sure all generated files are reproducible from .proto files. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Mar 1, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Mar 1, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Mar 1, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Mar 1, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Mar 1, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Mar 1, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Mar 1, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
What are we going to do about the use of |
kzys
added a commit
to kzys/containerd
that referenced
this issue
Mar 18, 2022
gogoproto.customtype is used to have go-digest.Digest instead of string. While it is convinient, protoc-gen-go doesn't support the extension and blocks containerd#6564. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/containerd
that referenced
this issue
Mar 18, 2022
gogoproto.customtype is used to have go-digest.Digest instead of string. While it is convinient, protoc-gen-go doesn't support the extension and blocks containerd#6564. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/containerd
that referenced
this issue
Mar 18, 2022
gogoproto.customtype is used to have go-digest.Digest instead of string. While it is convinient, protoc-gen-go doesn't support the extension and that blocks containerd#6564. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/imgcrypt
that referenced
this issue
Apr 20, 2022
containerd is migrating off from github.com/gogo/protobuf (see containerd/containerd#6564). However imgcrypt depends containerd and containerd also depends imgcrypt, which makes changing this signature complicated. This change workarounds the issue by using Go's reflect package. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/imgcrypt
that referenced
this issue
Apr 21, 2022
containerd is migrating off from github.com/gogo/protobuf (see containerd/containerd#6564). However imgcrypt depends containerd and containerd also depends imgcrypt, which makes changing this signature complicated. This change workarounds the issue by using Go's reflect package. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
akhilerm
pushed a commit
to akhilerm/containerd-api
that referenced
this issue
May 23, 2022
This commit removes gogoproto.stdtime, since it is not supported by Google's official toolchain (see containerd/containerd#6564). Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
akhilerm
pushed a commit
to akhilerm/containerd-api
that referenced
this issue
Jun 22, 2022
This commit removes gogoproto.stdtime, since it is not supported by Google's official toolchain (see containerd/containerd#6564). Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Aug 26, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Aug 26, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Aug 26, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Aug 26, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Aug 26, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Aug 26, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Aug 26, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Aug 26, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Aug 26, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Aug 26, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Aug 26, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Aug 26, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Aug 26, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Aug 26, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Oct 19, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/cgroups
that referenced
this issue
Nov 3, 2022
We'd like to migrate off from gogo/protobuf. The package is looking for new ownership since 2020. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
akhilerm
pushed a commit
to akhilerm/containerd-test
that referenced
this issue
Feb 22, 2023
This commit removes gogoproto.stdtime, since it is not supported by Google's official toolchain (see containerd/containerd#6564). Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com> Containerd-test-commit: 80b825c
akhilerm
pushed a commit
to akhilerm/containerd-test
that referenced
this issue
Feb 22, 2023
This commit removes gogoproto.stdtime, since it is not supported by Google's official toolchain (see containerd/containerd#6564). Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com> Containerd-test-commit: a8578f6
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this issue
Aug 29, 2024
containerd is planning to migrate off from github.com/gogo/protobuf which will affect hcsshim. See containerd/containerd#6564 for the overall progress. Before that, this commit runs Protobuild in GitHub Actions to make sure all generated files are reproducible from .proto files. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the problem you're trying to solve
We'd like to migrate off from github.com/gogo/protobuf. The package is looking for owners since 2020 and no longer compatible with https://go.dev/blog/protobuf-apiv2.
This is the master ticket to associate all PRs related to the migration.
Describe the solution you'd like
Use google.golang.org/protobuf instead.
We have removed gogo/protobuf and upgraded protobuf on the following packages.
https://github.com/containerd/protobuild
https://github.com/containerd/ttrpc
gogo/protobuf's code generation extension
There are multiple gogo/protobuf extensions which don't work with protoc-gen-go. That being said, those types are mostly invisible from our Go client. So we might be able to just follow Google's new convention (e.g. using protobuf's Time instead time.Time) instead of making them fully Go-idiomatic.
cpu
in proto becomesCpu
, notCPU
. We are discussing about the issue in protoc-gen-gogoctrd wouldn't work without gogo/protobuf #6219.Addressed
Fixed by #6699
github.com/opencontainers/go-digest.Digest
instead of string.Fixed by #6708
The text was updated successfully, but these errors were encountered: