Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to configure commintlint in package.json or with json/yaml file #73

Closed
pvdlg opened this issue Sep 16, 2017 · 2 comments
Closed

Allow to configure commintlint in package.json or with json/yaml file #73

pvdlg opened this issue Sep 16, 2017 · 2 comments
Labels
feature help wanted

Comments

@pvdlg
Copy link

pvdlg commented Sep 16, 2017

It would be convenient to allow commitlint to be configured within package.json or with a json or yaml file, similarly to eslint, prettier, stylelint etc...

cosmiconfig allow to do that pretty easily (as a replacement of rc).

Would you be open to such PR ?
@calebeby
Copy link

Haha I was just about to open this same issue

@marionebl
Copy link
Contributor

Sure, some help with this would be awesome.

pvdlg added a commit to pvdlg/commitlint that referenced this issue Sep 17, 2017
@pvdlg
feat(core): Allow to configure with json, yaml and package.json
2aabb1d 
Fix conventional-changelog#73
@pvdlg pvdlg mentioned this issue Sep 17, 2017
Closed
pvdlg added a commit to pvdlg/commitlint that referenced this issue Sep 17, 2017
@pvdlg
feat(core): Allow to configure with json, yaml and package.json
c2cbabf 
Fix conventional-changelog#73
pvdlg added a commit to pvdlg/commitlint that referenced this issue Sep 17, 2017
@pvdlg
feat(core): Allow to configure with json, yaml and package.json
8bc87e4 
Fix conventional-changelog#73
pvdlg added a commit to pvdlg/commitlint that referenced this issue Sep 19, 2017
@pvdlg
feat(core): Allow to configure with json, yaml and package.json
b22bea9 
Fix conventional-changelog#73
pvdlg added a commit to pvdlg/commitlint that referenced this issue Sep 20, 2017
@pvdlg
feat(core): Allow to configure with json, yaml and package.json
1f02fb3 
Fix conventional-changelog#73
pvdlg added a commit to pvdlg/commitlint that referenced this issue Sep 20, 2017
@pvdlg
feat(core): Allow to configure with json, yaml and package.json
063994d 
Fix conventional-changelog#73
pvdlg added a commit to pvdlg/commitlint that referenced this issue Sep 21, 2017
@pvdlg
feat(core): Allow to configure with json, yaml and package.json
2dcc27f 
Fix conventional-changelog#73
pvdlg added a commit to pvdlg/commitlint that referenced this issue Sep 21, 2017
@pvdlg
feat(core): Allow to configure with json, yaml and package.json
927b4f8 
Fix conventional-changelog#73
bpedersen pushed a commit to bpedersen/commitlint that referenced this issue Oct 15, 2019
@coolsp @juanpicado
fix: fixed failed to load all packages after login (conventional-chan…
7bac088 
…gelog#73)

A login forces react to reload the list of available packages (by changing the state).
However the state (which triggers react to refresh) is set before storing the login token resulting in fetching (XHR GET) only the public packages as the token is not yet available in the GET request.

Fixed by setting the storage items ('username' and 'token') before this.setLoggedUser().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature help wanted
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pvdlg @marionebl @calebeby