add requirements file of non-python dependencies - fix issue #34 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es), named "requirements.apt" - fix issue #34
…ependencies) listed on requirements.apt file
…ect (local, test, and production dependencies)
|
@pydanny @theskumar review me please if you are good, I'll do some documentation |
|
👍 |
| apt-get update | ||
|
|
||
| # Install the basic compilation dependencies and other required libraries of this project | ||
| cat requirements.apt | grep -v "#" | xargs sudo apt-get install -y |
There was a problem hiding this comment.
These commands will not only install all packages that are necessary, but will also upgrade any packages already installed to the latest version. That may not be a bad thing, but I prefer to err on the side of caution when doing root-level administration of somebody else's system. Having an --(no-)upgrade option, or at least warning the user in the docs that packages will be updated would be better.
add .idea on .gitignore
|
@pydanny @theskumar @dupuy I refactored the install_os_dependencies.sh file. Is good now or I missed some more error? |
|
👍 |
luzfcb
added a commit
that referenced
this pull request
Apr 13, 2015
add requirements file of non-python dependencies and helper scripts - fix issue #34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.