Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce memory thrashing in log search #314

Merged

Conversation

theseion
Copy link
Collaborator

@theseion theseion commented Jun 8, 2024

No description provided.

@theseion theseion requested a review from fzipi June 8, 2024 16:32
fzipi
fzipi previously approved these changes Jun 9, 2024
@fzipi fzipi changed the title Reduce memory thrashing in log search refactor: reduce memory thrashing in log search Jun 9, 2024
Reuse collections instead of allocating new ones for each test.
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, slices!

waflog/read.go Outdated Show resolved Hide resolved
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fzipi fzipi merged commit 74d760f into coreruleset:main Jun 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants