Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header getter/setter should be case in-sensitive #331

Merged

Conversation

huberts90
Copy link
Collaborator

No description provided.

@huberts90 huberts90 force-pushed the hsiwik/header-names-case-insensitive branch from 1ab40cd to 0d6d312 Compare July 9, 2024 11:31
ftwhttp/header.go Outdated Show resolved Hide resolved
ftwhttp/header.go Outdated Show resolved Hide resolved
ftwhttp/header.go Outdated Show resolved Hide resolved
ftwhttp/header.go Outdated Show resolved Hide resolved
ftwhttp/header.go Show resolved Hide resolved
ftwhttp/header.go Outdated Show resolved Hide resolved
ftwhttp/header.go Outdated Show resolved Hide resolved
ftwhttp/header_test.go Outdated Show resolved Hide resolved
ftwhttp/header_test.go Show resolved Hide resolved
ftwhttp/header_test.go Show resolved Hide resolved
Fix comment to the case in-sensitive keys
Move out test cases to separate methods
ftwhttp/header_test.go Outdated Show resolved Hide resolved
ftwhttp/header.go Outdated Show resolved Hide resolved
@theseion theseion merged commit 506d93d into coreruleset:main Jul 16, 2024
3 checks passed
@theseion
Copy link
Collaborator

Thanks!

@huberts90 huberts90 deleted the hsiwik/header-names-case-insensitive branch July 17, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants