Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow pending payments in checkout workflow #2481

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

solverat
Copy link
Contributor

Q A
Bug fix? sort of
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #2478

This PR allows pending payments (PaymentInterface::STATE_PROCESSING) in checkout:

  • show thank-you page even if payment is in state "processing"
  • respect process transition in OrderPaymentStateResolver
  • allow state PaymentInterface::STATE_PROCESSING to dispatch order confirmation (from new to confirmed

@dpfaffenbauer
Copy link
Member

looks good to me 💪

@dpfaffenbauer
Copy link
Member

@solverat I am waiting for the tests to finish. I guess we reached the hourly limit again with the runners. I will merge that today and do a release on friday

@dpfaffenbauer dpfaffenbauer added this to the 3.1.5 milestone Dec 14, 2023
@dpfaffenbauer dpfaffenbauer merged commit 80839e8 into coreshop:3.1 Dec 14, 2023
418 checks passed
@solverat solverat deleted the pending_payment branch December 14, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants