WIP: Distributed binary helm chart #1410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
…plates based on kind
jpds
reviewed
May 30, 2019
| securityContext: | ||
| readOnlyRootFilesystem: true | ||
| env: | ||
| - name: JAEGER_AGENT_HOST |
There was a problem hiding this comment.
This needs to be wrapped in an if like grafana/loki#621
jpds
reviewed
May 30, 2019
| replicas: 1 | ||
| enableService: true | ||
| http_listen_port: 8807 | ||
| serviceType: None |
There was a problem hiding this comment.
This breaks the deployment by default:
Error: release cortex-1559216564 failed: Service "cortex-1559216564-alertmanager" is invalid: spec.type: Unsupported value: "None": supported values: "ClusterIP", "ExternalName", "LoadBalancer", "NodePort"
|
closing this for now as another path for helm is coming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on the work in PR #1397, this change expands the helm chart to support cortex running in a distributed role/binary mode.
While some initial templates are being generated the following items are left to be done:
[ ] Generate correct config yaml with templated service names.
[ ] Update docs.
[ ] Test Installation.
[ ] Test Upgrading behaviour.