-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Release Notes and CHANGELOG for v0.41.1 (#8596)
- Loading branch information
1 parent
d2b8fea
commit a941e58
Showing
2 changed files
with
30 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,39 @@ | ||
| # Cosmos SDK v0.41.0 "Stargate" Release Notes | ||
| # Cosmos SDK v0.41.1 "Stargate" Release Notes | ||
|
|
||
| This release includes two breaking changes, and a few minor bugfixes. | ||
| This release includes two security patches, and does not introduce any breaking changes. It is **highly recommended** that all applications using v0.41.0 upgrade to v0.41.1 as soon as possible. | ||
|
|
||
| See the [Cosmos SDK v0.41.0 milestone](https://github.com/cosmos/cosmos-sdk/milestone/37?closed=1) on our issue tracker for details. | ||
| See the [Cosmos SDK v0.41.1 milestone](https://github.com/cosmos/cosmos-sdk/milestone/38?closed=1) on our issue tracker for details. | ||
|
|
||
| ### Support Amino JSON for IBC MsgTransfer | ||
| ### Security Patch #1: All gRPC requests are now routed through ABCI | ||
|
|
||
| This change **breaks state backward compatibility**. | ||
| When Tendermint commits a new block, the `versions` map in IAVL MutableTree is updated. If, at the same time, a concurrent gRPC request is performed, it will read the same `versions` map, causing the node to crash. | ||
|
|
||
| At the moment hardware wallets are [unable to sign messages using `SIGN_MODE_DIRECT` because the cosmos ledger app does not support proto encoding and`SIGN_MODE_TEXTUAL` is not available yet](https://https://github.com/cosmos/cosmos-sdk/issues/8266). | ||
| The patch consists of routing all gRPC requests through ABCI. The Go implementation of ABCI uses global lock on all requests, making them linearizable (received one at a time) which in turn prevents concurrent map reads and writes. | ||
|
|
||
| In order to enable hardware wallets users to interact with IBC, amino JSON support was added to `MsgTransfer` only. | ||
| We are exploring on ways of introducing concurrent gRPC queries in [#8591](https://github.com/cosmos/cosmos-sdk/issues/8591). | ||
|
|
||
| ### Counterparty.ChannelID not available in OnChanOpenAck callback implementation. | ||
| This bug has been reported via HackerOne. | ||
|
|
||
| This change **breaks state backward compatibility**. | ||
| ### Security Patch #2: Remove `GetValidator` cache map | ||
|
|
||
| In a previous version the `Counterparty.ChannelID` was available for an `OnChanOpenAck` callback implementation (read via `channelKeeper.GetChannel()`. Due to a regression, the channelID is currently empty. | ||
| The `x/staking` keeper holds an internal `validatorCache` cache map of validators. When multipile gRPC queries are performed simulataneously, concurrent reads and writes of this map can happen, causing the node to crash. | ||
|
|
||
| The issue has been fixed by reordering IBC `ChanOpenAck` and `ChanOpenConfirm` to execute the core handlers logic first, followed by application callbacks. | ||
| The patch removes the `validatorCache` altogether. Benchmarks show that the removal of the cache map even increases performance. | ||
|
|
||
| It breaks state backward compatibility because the current change consumes more gas, which means that in an updated node a TX might fail because it ran out of gas whilst in older versions it would be successful. | ||
| Is is important to note that the Security Patch #1 should also fix this bug, as it forces synchronous gRPC queries and therefore synchronous map reads/writes. However, it was deemed useful to include this bugfix too in this release. | ||
|
|
||
| ### Bug Fixes | ||
| ### Bug Fixes & Improvements | ||
|
|
||
| Now `x/bank` correctly verifies balances and metadata at init genesis stage. | ||
| Several bug fixes and non-breaking improvements are included in this release. | ||
|
|
||
| `simapp` correctly adds the coins of genesis accounts to supply. | ||
| Tendermint has been bumped to v0.34.4 to address a memory leak. | ||
|
|
||
| Environment variables are now correctly populated to CLI flags. When using the Tendermint subcommands `tendermint show-*` from the CLI, the SDK doesn't create new files anymore. | ||
|
|
||
| Keyring imports from older versions are fixed. | ||
|
|
||
| Additional validation for client denom metadata has been added. | ||
|
|
||
| On the IBC side, a `packet_connection` attribute has been added to IBC events to enable relayer filtering. | ||
|
|
||
| For the full change log, please see the [CHANGELOG](https://github.com/cosmos/cosmos-sdk/blob/v0.41.0/CHANGELOG.md). |