update error message and add tests (#8166)

cosmos · Dec 14, 2020 · ed5f120 · ed5f120
1 parent e4e3923
commit ed5f120
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/baseapp/params.go b/baseapp/params.go
@@ -64,7 +64,7 @@ func ValidateEvidenceParams(i interface{}) error {
 	}
 
 	if v.MaxBytes < 0 {
-		return fmt.Errorf("maximum evidence bytes must be positive: %v", v.MaxBytes)
+		return fmt.Errorf("maximum evidence bytes must be non-negative: %v", v.MaxBytes)
 	}
 
 	return nil

diff --git a/baseapp/params_test.go b/baseapp/params_test.go
@@ -37,7 +37,10 @@ func TestValidateEvidenceParams(t *testing.T) {
 		{&tmproto.EvidenceParams{}, true},
 		{tmproto.EvidenceParams{}, true},
 		{tmproto.EvidenceParams{MaxAgeNumBlocks: -1, MaxAgeDuration: 18004000, MaxBytes: 5000000}, true},
+		{tmproto.EvidenceParams{MaxAgeNumBlocks: 360000, MaxAgeDuration: -1, MaxBytes: 5000000}, true},
+		{tmproto.EvidenceParams{MaxAgeNumBlocks: 360000, MaxAgeDuration: 18004000, MaxBytes: -1}, true},
 		{tmproto.EvidenceParams{MaxAgeNumBlocks: 360000, MaxAgeDuration: 18004000, MaxBytes: 5000000}, false},
+		{tmproto.EvidenceParams{MaxAgeNumBlocks: 360000, MaxAgeDuration: 18004000, MaxBytes: 0}, false},
 	}
 
 	for _, tc := range testCases {