Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tendermint upgrade #10145

Closed
wants to merge 2 commits into from
Closed

chore: tendermint upgrade #10145

wants to merge 2 commits into from

Conversation

robert-zaremba
Copy link
Collaborator

This is a backport of pull request #10106.

@robert-zaremba robert-zaremba changed the base branch from master to release/v0.44.x September 14, 2021 16:03
@robert-zaremba robert-zaremba changed the title Robert/v0.44 tendermint upgrade chore: tendermint upgrade Sep 14, 2021
alexanderbez
alexanderbez reviewed Sep 14, 2021
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be go.sum changes?

@yun-yeo
Copy link
Contributor

yun-yeo commented Sep 15, 2021 •
edited
Loading

I'm sure, need #10040 before Tendermint@v0.34.13.
It introduced multi-reader feature, but previous iavl was not multi-thread safe but master is ok.

issue is cosmos/iavl#427

@amaury1093 amaury1093 mentioned this pull request Sep 16, 2021
Merged
@tac0turtle
Copy link
Member

this change is already housed in #10154. We can close this PR

@tac0turtle tac0turtle closed this Sep 16, 2021
@robert-zaremba robert-zaremba deleted the robert/v0.44-tendermint-upgrade branch September 16, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez left review comments

@alessio alessio Awaiting requested review from alessio

@clevinson clevinson Awaiting requested review from clevinson

@amaury1093 amaury1093 Awaiting requested review from amaury1093

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

@cmwaters cmwaters Awaiting requested review from cmwaters

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robert-zaremba @yun-yeo @tac0turtle @alexanderbez