Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grpc-only mode #11430

Merged
merged 16 commits into from
Mar 25, 2022
Merged

feat: grpc-only mode #11430

merged 16 commits into from
Mar 25, 2022

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Mar 21, 2022

Description

Closes: #10796

  • Add a new flag, grpc-only, which when enabled, starts the node with the gRPC and it's HTTP API variant only.
  • Housekeeping/code hygiene

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez marked this pull request as ready for review March 21, 2022 23:17
@alexanderbez alexanderbez added the C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. label Mar 21, 2022
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎉

Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. One nit comment to implicitly enable gRPC when grpc-only is set.

CHANGELOG.md Show resolved Hide resolved
server/start.go Show resolved Hide resolved
@@ -96,6 +94,12 @@ will not be able to commit subsequent blocks.

For profiling and benchmarking purposes, CPU profiling can be enabled via the '--cpu-profile' flag
which accepts a path for the resulting pprof file.

The node may be started in a 'query only' mode where only the gRPC and JSON HTTP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the queries from Tendermint supported in this mode? Stuff like block?

Copy link
Contributor Author

@alexanderbez alexanderbez Mar 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is gRPC only mode. The doc and implementation states Tendermint is disabled (i.e. not started). Tendermint cannot be supported.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it sync new state though?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because again, Tendermint is not running. This just serves existing data via gRPC.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh yeah, thank you & sorry for the dumb question. 😁

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No such thing :p

@tac0turtle tac0turtle merged commit 1880a7d into master Mar 25, 2022
@tac0turtle tac0turtle deleted the bez/10796-grpc-only-mode branch March 25, 2022 11:41
mergify bot pushed a commit that referenced this pull request Mar 25, 2022
* updates

* lint++

* updates

* updates

* updates

* updates

* cl++

* updates

Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit 1880a7d)

# Conflicts:
#	CHANGELOG.md
#	server/start.go
JimLarson pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Jul 7, 2022
randy75828 pushed a commit to Switcheo/cosmos-sdk that referenced this pull request Aug 10, 2022
randy75828 pushed a commit to Switcheo/cosmos-sdk that referenced this pull request Aug 10, 2022
Eengineer1 pushed a commit to cheqd/cosmos-sdk that referenced this pull request Aug 26, 2022
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: gRPC Issues and PRs related to the gRPC service and HTTP gateway.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run standalone gRPC server for serving historical queries
6 participants