Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: EPIC: App Wiring #12385

Closed
wants to merge 4 commits into from
Closed

feat: EPIC: App Wiring #12385

wants to merge 4 commits into from

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jun 29, 2022

Description

Port of #12366 and #12270


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

* progress

* simapp out

* add files

* Update x/feegrant/simulation/operations_test.go

Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>

* updates comments

Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@julienrbrt julienrbrt changed the title EPIC: App Wiring feat: EPIC: App Wiring Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #12385 (1194321) into main (ccb0081) will decrease coverage by 0.15%.
The diff coverage is 92.30%.

❗ Current head 1194321 differs from pull request most recent head 1e80f52. Consider uploading reports for the commit 1e80f52 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12385      +/-   ##
==========================================
- Coverage   65.82%   65.67%   -0.16%     
==========================================
  Files         676      676              
  Lines       71425    71429       +4     
==========================================
- Hits        47018    46911     -107     
- Misses      21770    21878     +108     
- Partials     2637     2640       +3     
Impacted Files Coverage Δ
x/feegrant/module/module.go 44.94% <0.00%> (-11.24%) ⬇️
x/feegrant/client/testutil/suite.go 88.36% <100.00%> (-11.30%) ⬇️
x/feegrant/simulation/operations.go 83.63% <100.00%> (ø)
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️
x/group/keeper/keeper.go 58.66% <0.00%> (+0.39%) ⬆️

protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import

Certain system packages contain functions which may be a possible source of non-determinism
@julienrbrt julienrbrt closed this Jun 29, 2022
@julienrbrt julienrbrt reopened this Jun 29, 2022
@julienrbrt julienrbrt changed the title feat: EPIC: App Wiring feat: decouple x/feegrant and simapp and migrate x/crisis to app wiring Jun 29, 2022
@julienrbrt julienrbrt marked this pull request as ready for review June 29, 2022 16:08
@julienrbrt julienrbrt requested a review from a team as a code owner June 29, 2022 16:08
@github-actions github-actions bot added C:x/distribution distribution module related C:x/upgrade and removed C:x/slashing labels Jun 29, 2022
@julienrbrt julienrbrt closed this Jun 29, 2022
@julienrbrt julienrbrt deleted the epic/app-wiring branch June 29, 2022 16:29
@julienrbrt julienrbrt changed the title feat: decouple x/feegrant and simapp and migrate x/crisis to app wiring feat: EPIC: App Wiring Jun 29, 2022
@julienrbrt
Copy link
Member Author

We are not using a feature branch so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants