Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to CometBFT in v0.47 #15060

Merged
merged 8 commits into from
Feb 20, 2023
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Feb 17, 2023

Description

ref: #14870

  • No variable or package renaming or aliases (these will happen from v0.48), only imports
  • Fix API break from CometBFT in rollback.go
  • No migration to cometbft/cometbft-db and still using tendermint/tm-db, other we need IAVL to migrate in a point version too (and thus use cometbft/cometbft-db in v0.45 and v0.46 as well) Migration to cometbft/cometbft-db done in IAVL, so done here.
  • No standalone go.mod updates, except for rosetta.
    (https://github.com/cosmos/cosmos-sdk/actions/runs/4204024282/jobs/7294151595)

TODO (follow-ups)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:Rosetta Issues and PR related to Rosetta label Feb 17, 2023
@julienrbrt
Copy link
Member Author

julienrbrt commented Feb 17, 2023

To go further, we need the release/v0.19.x of IAVL to remove it's tendermint/tendermint dep.
ref: cosmos/iavl#682

@julienrbrt
Copy link
Member Author

julienrbrt commented Feb 18, 2023

As discussed, we are going to use the IAVL v0.20.x line after this PR (cosmos/iavl#683), as we cannot remove the TM deps in the v0.19.x as hopped here: #15060 (comment).
We are blocked on the merging to the above-mentioned PR. Yet with the pseudo version, everything works just fine.

No more code change is going to happen here, except the bump to a tagged version of IAVL and CometBFT. So it can already be reviewed (but it's still blocked).

@julienrbrt julienrbrt marked this pull request as ready for review February 18, 2023 21:05
@julienrbrt julienrbrt requested a review from a team as a code owner February 18, 2023 21:05
@julienrbrt julienrbrt requested review from a team, aaronc and testinginprod and removed request for a team February 18, 2023 21:12
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tac0turtle tac0turtle removed the S:blocked Status: Blocked label Feb 20, 2023
@julienrbrt julienrbrt merged commit 8b60d41 into release/v0.47.x Feb 20, 2023
@julienrbrt julienrbrt deleted the julien/047-cometbft branch February 20, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants