feat: More flexibility for `CacheMultiStoreWithVersion` #15683

catShaark · 2023-04-03T18:45:05Z

Description

The gaia v9 upgrade causes node to errors out when querying historical states before the upgrade. This is because we added a new module store in the upgrade which is the provider module store. Thus, every times we load the multi store for querying at a height prior to the upgrade, we try to load the provider module store and fail since it has not existed before the upgrade.

I make changes to CacheMultiStoreWithVersion so that if we fail to load any module store at a given height, we check if that module store has existed at that height or not (using getCommitInfo()), we can ignore the error if the store hasn't existed at that given height.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

store/rootmulti/store.go

alexanderbez

LGTM. Please add a changelog

store/rootmulti/store.go

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

catShaark · 2023-04-07T12:05:48Z

changelog added

store/CHANGELOG.md

julienrbrt

utACK

store/rootmulti/store.go

julienrbrt · 2023-04-10T20:28:33Z

I think this improvement should go in v0.46 as well. Adding the backport label. Someone feel free to remove it if you think otherwise.

## Description Closes: [cosmos/gaia#2313](cosmos/gaia#2313) The gaia v9 upgrade causes node to errors out when querying historical states before the upgrade. This is because we added a new module store in the upgrade which is the `provider module store`. Thus, every times we load the multi store for querying at a height prior to the upgrade, we try to load the `provider module store` and fail since it has not existed before the upgrade. I make changes to `CacheMultiStoreWithVersion` so that if we fail to load any module store at a given height, we check if that module store has existed at that height or not (using `getCommitInfo()`), we can ignore the error if the store hasn't existed at that given height. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... * [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title * [ ] added `!` to the type prefix if API or client breaking change * [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) * [ ] provided a link to the relevant issue or specification * [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules) * [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) * [ ] added a changelog entry to `CHANGELOG.md` * [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) * [ ] updated the relevant documentation or specification * [ ] reviewed "Files changed" and left comments if necessary * [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... * [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title * [ ] confirmed `!` in the type prefix if API or client breaking change * [ ] confirmed all author checklist items have been addressed * [ ] reviewed state machine logic * [ ] reviewed API design and naming * [ ] reviewed documentation is accurate * [ ] reviewed tests and test coverage * [ ] manually tested (if applicable) (cherry picked from commit d5a618d) # Conflicts: # store/CHANGELOG.md

mmulji-ic · 2023-04-11T08:04:48Z

@julienrbrt could we have this backported to 0.45.x?

) (#15775) Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

) (#15774) Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

julienrbrt · 2023-04-11T14:52:05Z

@julienrbrt could we have this backported to 0.45.x?

The SDK v0.45.x line has reached end-of-life, with its last version being v0.45.15.
This PR is getting in v0.46.x and v0.47.x, so we recommend you to upgrade to one of these versions.

* fix: create snapshot dir for rocksdb backend (backport cosmos#15054) (cosmos#15065) Co-authored-by: yihuang <huang@crypto.com> * chore: Add check for uneven stores' height (backport cosmos#14410) (cosmos#15115) Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * refactor!: remove store v2alpha1 (cosmos#15152) * build: use cometbft in v0.46 (cosmos#15090) * chore: bump cometbft to v0.34.27 final (cosmos#15206) * fix: Change proposer address cast for `sdk_block` conversion (backport cosmos#15243) (cosmos#15245) Co-authored-by: Maksym Hontar <99190705+max-hontar@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: revert double close fix (cosmos#15255) * chore: prepare v0.46.11 release (cosmos#15259) * feat: add extend cb to avoid unmarshal state twice for sim test (backport: cosmos#15305) (cosmos#15321) * feat: add extend cb with genesisState for sim test (backport: cosmos#15305) (cosmos#15349) * fix: add extra check in vesting (backport cosmos#15373) (cosmos#15383) Co-authored-by: Julien Robert <julien@rbrt.fr> * docs: update cosmwasm link (cosmos#15441) * fix: remove extra `;` in service.proto (cosmos#15443) * fix: flaky group genesis sim (backport cosmos#15447) (cosmos#15461) Co-authored-by: Robert Zaremba <robert@zaremba.ch> * feat: add delegator to withdraw address (backport cosmos#15462) (cosmos#15473) Co-authored-by: Marko <marbar3778@yahoo.com> * docs: improve proto vesting docs about time attributes (backport cosmos#15474) (cosmos#15481) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: add query `groups` in `x/group` (backport cosmos#14879) (cosmos#15476) Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: Makefile rocksdb (backport cosmos#15422) (cosmos#15525) Co-authored-by: Robert Zaremba <robert@zaremba.ch> * fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667) Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * fix: remove unnecessary cms typecasting (backport cosmos#14054) (cosmos#15669) Co-authored-by: Javier Su <javier.su.weijie@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.46.12 release notes (cosmos#15685) * fix: upstream error on empty version (backport cosmos#13355) (cosmos#15717) Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: More flexibility for `CacheMultiStoreWithVersion` (backport cosmos#15683) (cosmos#15775) Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: add moduleStateCb to allow access moduleState in sim test (backport cosmos#15903) (cosmos#15925) Co-authored-by: mmsqe <tqd0800210105@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): bump cometbft to v0.34.28 (cosmos#15973) * chore(gov): improve proposal conversion error message (backport cosmos#15979) (cosmos#15981) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * feat!: bootstrap comet cmd for local state sync (backport cosmos#16061) (cosmos#16080) Co-authored-by: Marko <marbar3778@yahoo.com> * chore(auth/vesting): fix typo in `create-period-vesting-account` cmd example (backport cosmos#16085) (cosmos#16087) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: add local snapshots management commands (backport cosmos#16067) (cosmos#16103) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: snapshot commands panic if snapshot don't exists (backport cosmos#16138) (cosmos#16140) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: add Close method for resource cleanup in graceful shutdown (backport cosmos#16193) (cosmos#16205) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: save restored snapshot locally (backport cosmos#16060) (cosmos#16262) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * chore: update sidebar v0.46 (cosmos#16304) * chore: add baseapp circuit breaker setter (cosmos#16289) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: allow any address in `ValidatePromptAddress` (backport cosmos#16312) (cosmos#16314) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(group): add group event tally result (backport cosmos#16191) (cosmos#16306) Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: Revert "fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667)" (cosmos#16331) * chore: prepare v0.46.13 (cosmos#16249) * chore: small snapshot commands & docs improvement (backport cosmos#16404) (cosmos#16409) Co-authored-by: Julien Robert <julien@rbrt.fr> * Add the quarantine and sanction stores to the import-export sim test. * refactor: avoid breaking change due to cosmos#16415 included in v0.50 (backport cosmos#16430) (cosmos#16432) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Facundo Medica <facundomedica@gmail.com> * chore: prepare v0.46.13 (2/2) (cosmos#16443) * fix: patch barberry (cosmos#16466) * Better gov prop error handling. * Fix the group sims random genesis so it can't pick the same account twice for the group policies since that address is the primary key for the table. Also, output the genesis state after it's randomized just like all the other modules do. * Add changelog entries. * Regen the swagger docs. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Maksym Hontar <99190705+max-hontar@users.noreply.github.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Javier Su <javier.su.weijie@gmail.com> Co-authored-by: mmsqe <tqd0800210105@gmail.com> Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com> Co-authored-by: Facundo Medica <facundomedica@gmail.com>

* fix: create snapshot dir for rocksdb backend (backport cosmos#15054) (cosmos#15065) * chore: Add check for uneven stores' height (backport cosmos#14410) (cosmos#15115) * refactor!: remove store v2alpha1 (cosmos#15152) * build: use cometbft in v0.46 (cosmos#15090) * chore: bump cometbft to v0.34.27 final (cosmos#15206) * fix: Change proposer address cast for `sdk_block` conversion (backport cosmos#15243) (cosmos#15245) * fix: revert double close fix (cosmos#15255) * chore: prepare v0.46.11 release (cosmos#15259) * feat: add extend cb to avoid unmarshal state twice for sim test (backport: cosmos#15305) (cosmos#15321) * feat: add extend cb with genesisState for sim test (backport: cosmos#15305) (cosmos#15349) * fix: add extra check in vesting (backport cosmos#15373) (cosmos#15383) * docs: update cosmwasm link (cosmos#15441) * fix: remove extra `;` in service.proto (cosmos#15443) * fix: flaky group genesis sim (backport cosmos#15447) (cosmos#15461) * feat: add delegator to withdraw address (backport cosmos#15462) (cosmos#15473) * docs: improve proto vesting docs about time attributes (backport cosmos#15474) (cosmos#15481) * feat: add query `groups` in `x/group` (backport cosmos#14879) (cosmos#15476) * fix: Makefile rocksdb (backport cosmos#15422) (cosmos#15525) * fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667) * fix: remove unnecessary cms typecasting (backport cosmos#14054) (cosmos#15669) * chore: prepare v0.46.12 release notes (cosmos#15685) * fix: upstream error on empty version (backport cosmos#13355) (cosmos#15717) * feat: More flexibility for `CacheMultiStoreWithVersion` (backport cosmos#15683) (cosmos#15775) * feat: add moduleStateCb to allow access moduleState in sim test (backport cosmos#15903) (cosmos#15925) * build(deps): bump cometbft to v0.34.28 (cosmos#15973) * chore(gov): improve proposal conversion error message (backport cosmos#15979) (cosmos#15981) * feat!: bootstrap comet cmd for local state sync (backport cosmos#16061) (cosmos#16080) * chore(auth/vesting): fix typo in `create-period-vesting-account` cmd example (backport cosmos#16085) (cosmos#16087) * feat: add local snapshots management commands (backport cosmos#16067) (cosmos#16103) * fix: snapshot commands panic if snapshot don't exists (backport cosmos#16138) (cosmos#16140) * feat: add Close method for resource cleanup in graceful shutdown (backport cosmos#16193) (cosmos#16205) * feat: save restored snapshot locally (backport cosmos#16060) (cosmos#16262) * chore: update sidebar v0.46 (cosmos#16304) * chore: add baseapp circuit breaker setter (cosmos#16289) * fix: allow any address in `ValidatePromptAddress` (backport cosmos#16312) (cosmos#16314) * feat(group): add group event tally result (backport cosmos#16191) (cosmos#16306) * fix: Revert "fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667)" (cosmos#16331) * chore: prepare v0.46.13 (cosmos#16249) * chore: small snapshot commands & docs improvement (backport cosmos#16404) (cosmos#16409) * Add the quarantine and sanction stores to the import-export sim test. * refactor: avoid breaking change due to cosmos#16415 included in v0.50 (backport cosmos#16430) (cosmos#16432) * chore: prepare v0.46.13 (2/2) (cosmos#16443) * fix: patch barberry (cosmos#16466) * Better gov prop error handling. * Fix the group sims random genesis so it can't pick the same account twice for the group policies since that address is the primary key for the table. Also, output the genesis state after it's randomized just like all the other modules do. * Add changelog entries. * Regen the swagger docs. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Maksym Hontar <99190705+max-hontar@users.noreply.github.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Javier Su <javier.su.weijie@gmail.com> Co-authored-by: mmsqe <tqd0800210105@gmail.com> Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com> Co-authored-by: Facundo Medica <facundomedica@gmail.com>

…mos#15683) (cosmos#15774) Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

Closes: [cosmos/gaia#2313](cosmos/gaia#2313) The gaia v9 upgrade causes node to errors out when querying historical states before the upgrade. This is because we added a new module store in the upgrade which is the `provider module store`. Thus, every times we load the multi store for querying at a height prior to the upgrade, we try to load the `provider module store` and fail since it has not existed before the upgrade. I make changes to `CacheMultiStoreWithVersion` so that if we fail to load any module store at a given height, we check if that module store has existed at that height or not (using `getCommitInfo()`), we can ignore the error if the store hasn't existed at that given height. --- *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... * [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title * [ ] added `!` to the type prefix if API or client breaking change * [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) * [ ] provided a link to the relevant issue or specification * [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules) * [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) * [ ] added a changelog entry to `CHANGELOG.md` * [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) * [ ] updated the relevant documentation or specification * [ ] reviewed "Files changed" and left comments if necessary * [ ] confirmed all CI checks have passed *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... * [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title * [ ] confirmed `!` in the type prefix if API or client breaking change * [ ] confirmed all author checklist items have been addressed * [ ] reviewed state machine logic * [ ] reviewed API design and naming * [ ] reviewed documentation is accurate * [ ] reviewed tests and test coverage * [ ] manually tested (if applicable)

* feat: More flexibility for `CacheMultiStoreWithVersion` (cosmos#15683) Closes: [cosmos/gaia#2313](cosmos/gaia#2313) The gaia v9 upgrade causes node to errors out when querying historical states before the upgrade. This is because we added a new module store in the upgrade which is the `provider module store`. Thus, every times we load the multi store for querying at a height prior to the upgrade, we try to load the `provider module store` and fail since it has not existed before the upgrade. I make changes to `CacheMultiStoreWithVersion` so that if we fail to load any module store at a given height, we check if that module store has existed at that height or not (using `getCommitInfo()`), we can ignore the error if the store hasn't existed at that given height. --- *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... * [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title * [ ] added `!` to the type prefix if API or client breaking change * [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) * [ ] provided a link to the relevant issue or specification * [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules) * [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) * [ ] added a changelog entry to `CHANGELOG.md` * [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) * [ ] updated the relevant documentation or specification * [ ] reviewed "Files changed" and left comments if necessary * [ ] confirmed all CI checks have passed *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... * [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title * [ ] confirmed `!` in the type prefix if API or client breaking change * [ ] confirmed all author checklist items have been addressed * [ ] reviewed state machine logic * [ ] reviewed API design and naming * [ ] reviewed documentation is accurate * [ ] reviewed tests and test coverage * [ ] manually tested (if applicable) * fix merge conflict

Closes: [cosmos/gaia#2313](cosmos/gaia#2313) The gaia v9 upgrade causes node to errors out when querying historical states before the upgrade. This is because we added a new module store in the upgrade which is the `provider module store`. Thus, every times we load the multi store for querying at a height prior to the upgrade, we try to load the `provider module store` and fail since it has not existed before the upgrade. I make changes to `CacheMultiStoreWithVersion` so that if we fail to load any module store at a given height, we check if that module store has existed at that height or not (using `getCommitInfo()`), we can ignore the error if the store hasn't existed at that given height. --- *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... * [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title * [ ] added `!` to the type prefix if API or client breaking change * [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) * [ ] provided a link to the relevant issue or specification * [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules) * [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) * [ ] added a changelog entry to `CHANGELOG.md` * [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) * [ ] updated the relevant documentation or specification * [ ] reviewed "Files changed" and left comments if necessary * [ ] confirmed all CI checks have passed *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... * [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title * [ ] confirmed `!` in the type prefix if API or client breaking change * [ ] confirmed all author checklist items have been addressed * [ ] reviewed state machine logic * [ ] reviewed API design and naming * [ ] reviewed documentation is accurate * [ ] reviewed tests and test coverage * [ ] manually tested (if applicable)

…mos#15683) (cosmos#15775) Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

modify CacheMultiStoreWithVersion and add test

a0a1e39

catShaark requested a review from a team as a code owner April 3, 2023 18:45

Merge branch 'main' into cacheMultiStorewithVersion

941bbce

github-actions bot added the C:Store label Apr 3, 2023

Merge branch 'main' into cacheMultiStorewithVersion

c527168

alexanderbez suggested changes Apr 4, 2023

View reviewed changes

store/rootmulti/store.go Show resolved Hide resolved

Merge branch 'main' into cacheMultiStorewithVersion

eea3536

alexanderbez approved these changes Apr 5, 2023

View reviewed changes

store/rootmulti/store.go Show resolved Hide resolved

Merge branch 'main' into cacheMultiStorewithVersion

09035b8

alexanderbez reviewed Apr 6, 2023

View reviewed changes

store/rootmulti/store.go Outdated Show resolved Hide resolved

alexanderbez approved these changes Apr 6, 2023

View reviewed changes

Merge branch 'main' into cacheMultiStorewithVersion

ea2e98c

This was referenced Apr 7, 2023

upgrade to 47 OmniFlix/omniflixhub#49

Closed

Upgrade to 47 OmniFlix/omniflixhub#50

Closed

catShaark and others added 3 commits April 7, 2023 18:53

Update store/rootmulti/store.go

c799fcd

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

update CHANGELOG.md

069b4fe

Merge branch 'main' into cacheMultiStorewithVersion

bbde061

julienrbrt reviewed Apr 7, 2023

View reviewed changes

store/CHANGELOG.md Outdated Show resolved Hide resolved

catShaark and others added 2 commits April 7, 2023 19:10

Merge branch 'main' into cacheMultiStorewithVersion

88dd3d9

update CHANGELOG.md

c5577b7

julienrbrt reviewed Apr 7, 2023

View reviewed changes

store/CHANGELOG.md Outdated Show resolved Hide resolved

update CHANGELOG.md

1f045b4

julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Apr 7, 2023

Merge branch 'main' into cacheMultiStorewithVersion

f09331c

julienrbrt approved these changes Apr 7, 2023

View reviewed changes

alexanderbez approved these changes Apr 7, 2023

View reviewed changes

Merge branch 'main' into cacheMultiStorewithVersion

c90d699

08d2 reviewed Apr 9, 2023

View reviewed changes

store/rootmulti/store.go Outdated Show resolved Hide resolved

Merge branch 'main' into cacheMultiStorewithVersion

ede8ca0

minor

04d4f1a

alexanderbez approved these changes Apr 10, 2023

View reviewed changes

Merge branch 'main' into cacheMultiStorewithVersion

6da1acc

julienrbrt added backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release A:automerge Automatically merge PR once all prerequisites pass. labels Apr 10, 2023

mergify bot merged commit d5a618d into cosmos:main Apr 10, 2023

This was referenced Apr 10, 2023

feat: More flexibility for CacheMultiStoreWithVersion (backport #15683) #15774

Merged

feat: More flexibility for CacheMultiStoreWithVersion (backport #15683) #15775

Merged

glnro mentioned this pull request Apr 14, 2023

Unable to query archival data with recent upgrade 14470501 cosmos/gaia#2313

Closed

5 tasks

faddat mentioned this pull request Jun 8, 2023

barberry realiotech/cosmos-sdk#30

Merged

evan-forbes mentioned this pull request Jun 11, 2023

chore!: prepare process proposal state celestiaorg/cosmos-sdk#326

Merged

LampardNguyen234 mentioned this pull request Aug 15, 2023

deps: bump cosmos-sdk v0.46 and evmos v12 AstraProtocol/astra#209

Merged

haiyizxx added a commit to axelarnetwork/cosmos-sdk that referenced this pull request Mar 21, 2024

fix: repalce v0.46 api used cosmos#15683 with current version

47c0c80

0xstepit mentioned this pull request Jul 1, 2024

chore(cachemulti): add Copy method evmos/cosmos-sdk#52

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: More flexibility for `CacheMultiStoreWithVersion` #15683

feat: More flexibility for `CacheMultiStoreWithVersion` #15683

catShaark commented Apr 3, 2023

alexanderbez left a comment

catShaark commented Apr 7, 2023

julienrbrt left a comment

julienrbrt commented Apr 10, 2023

mmulji-ic commented Apr 11, 2023

julienrbrt commented Apr 11, 2023

feat: More flexibility for CacheMultiStoreWithVersion #15683

feat: More flexibility for CacheMultiStoreWithVersion #15683

Conversation

catShaark commented Apr 3, 2023

Description

Author Checklist

Reviewers Checklist

alexanderbez left a comment

Choose a reason for hiding this comment

catShaark commented Apr 7, 2023

julienrbrt left a comment

Choose a reason for hiding this comment

julienrbrt commented Apr 10, 2023

mmulji-ic commented Apr 11, 2023

julienrbrt commented Apr 11, 2023

feat: More flexibility for `CacheMultiStoreWithVersion` #15683

feat: More flexibility for `CacheMultiStoreWithVersion` #15683