Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdkv47 ics #15856

Closed
wants to merge 2 commits into from
Closed

Sdkv47 ics #15856

wants to merge 2 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Apr 17, 2023

Description

Draft PR for comparison and collection of opinions

Note: please don't treat this as a regular PR. This is for comparison.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle
Copy link
Member

tac0turtle commented Apr 17, 2023

ics changes are already on main and 0.47, no need for this. You can open this pro in your fork if needed

@tac0turtle tac0turtle closed this Apr 17, 2023
@faddat
Copy link
Contributor Author

faddat commented Apr 18, 2023

@tac0turtle can you please re-check?

I think that the latest status of this is that Informal now recognizes that changes are needed. We'll need to discuss more.

@faddat
Copy link
Contributor Author

faddat commented Apr 20, 2023

@tac0turtle - it seems that Informalinc thinks that these changes will be needed, too. Can you please advise how to proceed?

@tac0turtle
Copy link
Member

it would be good to get an explanation about this change and why they require it.

@faddat
Copy link
Contributor Author

faddat commented Apr 25, 2023

We have been asking in slack, on GitHub, and in many other places. Please keep in mind that it is not just the informal team that needs this, it is the hub that needs this. When we made this pull request, we were being told by informal that this work was not needed.

@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2023

⚠️ The sha of the head commit of this PR conflicts with #15940. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants