Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store): remove comet.Header usage in store #16326

Closed
wants to merge 17 commits into from

Conversation

tac0turtle
Copy link
Member

Description

this pr does two things:

  • remove header from store as we only need header info
  • add WithHeaderIno to places we call Blockheader
  • Depreactes functions on context that headerinfo and cometinfo replace

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle changed the title add withHeaderInfo to needed places, mark functions as depreacted refactor(store): remove comet.Header usage in store May 29, 2023
Height: req.Height,
Time: req.Time,
Hash: req.Hash}).
WithCometInfo(cometInfo{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear why these were removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there was some confusion of what to do with the Header type and Context type

Base automatically changed from marko/remove_comet_store to main May 30, 2023 15:52
@github-actions github-actions bot added C:Confix Issues and PR related to Confix C:Rosetta Issues and PR related to Rosetta C:x/circuit C:x/evidence C:x/feegrant C:x/nft C:x/upgrade labels May 30, 2023
baseapp/test_helpers.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the C:CLI label May 30, 2023
@tac0turtle tac0turtle marked this pull request as ready for review May 31, 2023 07:25
@tac0turtle tac0turtle requested a review from a team as a code owner May 31, 2023 07:25
@github-actions github-actions bot removed C:x/evidence C:Rosetta Issues and PR related to Rosetta C:x/circuit C:x/nft C:Confix Issues and PR related to Confix labels May 31, 2023
@tac0turtle
Copy link
Member Author

ill wait for #16342 to be merged to merge this.

@tac0turtle tac0turtle marked this pull request as draft May 31, 2023 07:26
@tac0turtle tac0turtle added the S:blocked Status: Blocked label Jun 8, 2023
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Jul 10, 2023
@github-actions github-actions bot closed this Jul 14, 2023
@tac0turtle tac0turtle deleted the marko/remove_header_store branch February 21, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants