Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): complete branch KVStore #17925

Merged
merged 16 commits into from
Oct 5, 2023

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Sep 28, 2023

Description

Completes the branchkv.Store implementation, excluding tracing which will be done later in another PR.

The branchkv.Store will act as the main KVStore used in store v2. It handles branching and allows changesets to be accumulated which are flushed to SC and SS during Commit().


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez marked this pull request as ready for review October 2, 2023 19:12
@alexanderbez alexanderbez requested a review from a team as a code owner October 2, 2023 19:12
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

@alexanderbez your pull request is missing a changelog!

Copy link
Collaborator

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and code wise LGTM, thank you @alexanderbez!

store/branchkv/iterator.go Outdated Show resolved Hide resolved
store/change_set.go Outdated Show resolved Hide resolved
@alexanderbez alexanderbez merged commit 55c09f3 into feature/store-v2 Oct 5, 2023
45 of 47 checks passed
@alexanderbez alexanderbez deleted the bez/store-v2-branch-kvstore branch October 5, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants