feat: Integrate grpc configuration into client.toml #19905
Conversation
WalkthroughWalkthroughThe recent updates encompass the addition of a gRPC client configuration to the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
lucaslopezf
changed the title
|
Some doubts:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: .coderabbit.yml
Files selected for processing (5)
- CHANGELOG.md (2 hunks)
- client/config/config.go (4 hunks)
- client/config/config_test.go (2 hunks)
- client/config/toml.go (2 hunks)
- simapp/simd/cmd/config.go (1 hunks)
Additional Context Used
Path-based Instructions (5)
client/config/toml.go (1)
**/*.go:
Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.simapp/simd/cmd/config.go (1)
**/*.go:
Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.client/config/config_test.go (2)
**/*.go:
Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
**/*_test.go:
Assess the unit test code assessing sufficient code coverage for the changes associated in the pull requestclient/config/config.go (1)
**/*.go:
Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.CHANGELOG.md (1)
**/*.md:
Assess the documentation for misspellings, grammatical errors, missing documentation and correctness
Additional comments not posted (10)
client/config/toml.go (2)
12-12: The introduction ofCustomConfigKeyas a placeholder for custom configurations is a good practice for enhancing the flexibility and maintainability of configuration files.
33-52: The update toDefaultClientConfigTemplateto include placeholders for custom and gRPC configurations is well-implemented. This change enhances the clarity and scalability of the configuration file by ensuring that custom settings are correctly applied.simapp/simd/cmd/config.go (1)
59-69: The refactoring ininitClientConfigto introduce and integrate custom configuration settings into the default configuration template is well-executed. The use of structured configuration and theCustomizeConfigTemplatefunction enhances the maintainability and scalability of the configuration management.client/config/config_test.go (2)
83-90: The update to useCustomizeConfigTemplatefor generating thecustomClientConfigTemplatein tests is a good practice, ensuring that custom configurations are correctly integrated. This enhances the test's relevance and accuracy.
185-202: The addition ofTestGRPCConfigis a valuable enhancement to the test suite, ensuring the correct setup of gRPC configurations within the client configuration. This test is well-structured and covers the necessary assertions to verify the functionality.client/config/config.go (3)
48-51: The introduction of theGRPCConfigstruct to encapsulate gRPC client settings is a significant enhancement. It aligns with the PR's objectives and follows best practices for configuration management.
176-195: The addition of thegetGRPCClientfunction and its integration into the client configuration setup is well-implemented. It correctly handles the creation of gRPC clients based on the configuration, supporting both secure and insecure connections. This is a crucial enhancement for the gRPC client configuration feature.
4-12: The imports forgrpc,grpc/credentials, andgrpc/credentials/insecureare correctly added to support the new gRPC client configuration functionality. These imports are essential for establishing secure and insecure gRPC connections.CHANGELOG.md (2)
45-45: The Features section accurately reflects significant additions to the Cosmos SDK. Ensure the PR links and descriptions are accurate and relevant to the changes made.
63-63: The Improvements section clearly outlines enhancements made to the Cosmos SDK. Verify the accuracy of the PR links and ensure the descriptions accurately reflect the changes.
lucaslopezf
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: .coderabbit.yml
Files selected for processing (4)
- CHANGELOG.md (1 hunks)
- client/config/config.go (3 hunks)
- client/config/config_test.go (2 hunks)
- client/config/toml.go (2 hunks)
Files skipped from review as they are similar to previous changes (4)
- CHANGELOG.md
- client/config/config.go
- client/config/config_test.go
- client/config/toml.go
Additional Context Used
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: .coderabbit.yml
Files selected for processing (1)
- client/config/toml.go (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- client/config/toml.go
Additional Context Used
* main: (45 commits) build(deps): Bump github.com/decred/dcrd/dcrec/secp256k1/v4 from 4.2.0 to 4.3.0 (cosmos#19913) build(deps): Bump google.golang.org/grpc from 1.62.1 to 1.63.0 (cosmos#19929) test(types/address): add additional unit tests for address.LengthPrefix and a… (cosmos#19964) refactor(x/bank)!: remove Address.String() (cosmos#19954) build(deps): Bump github.com/prometheus/common from 0.51.1 to 0.52.2 (cosmos#19930) fix(x/epochs): Fix init genesis (cosmos#19958) feat(core,runtime): transaction service (exec mode) (cosmos#19953) fix(x/authz): non utf-8 characters in logs (cosmos#19923) build(deps): Bump golang.org/x/crypto from 0.21.0 to 0.22.0 (cosmos#19960) chore: fix spelling errors (cosmos#19957) fix(x/tx): don't shadow Amino marshalling error messages (cosmos#19955) refactor(types): loosen module.AppModule interface (cosmos#19951) feat(core): add `TxValidator` interface (cosmos#19950) build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 in /x/epochs (cosmos#19947) feat(x/epochs): upstream osmosis epoch module (cosmos#19697) build(deps): Bump bufbuild/buf-setup-action from 1.30.0 to 1.30.1 (cosmos#19928) refactor(x/genutil)!: remove Address.String() (cosmos#19926) docs(x/mint): Fix inconsistency in mint docs (cosmos#19915) build(deps): Bump github.com/regen-network/gocuke from 1.1.0 to 1.1.1 in /orm (cosmos#19920) feat: Integrate grpc configuration into client.toml (cosmos#19905) ...
Description
Closes: #19120
Changes
client.tomlAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit