types/rest: add unit tests

[alessio]

Drop unused functions:

• ParseQueryParamBool()
• ParseInt64OrReturnBadRequest()

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

---

For admin use:

• Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• Reviewers assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[alexanderbez]

Weird -- I swear these were used before. ACK

[alessio]

@alexanderbez dixit:

Weird -- I swear these were used before. ACK

I was surprised too! AFAICS ParseInt64OrReturnBadRequest was introduced first in #1918, and seems to have been deprecated in favor of ParseUint64OrReturnBadRequest over time. Whilst ParseQueryParamBool was introduced by @fedekunze in #5585. @fedekunze: should we keep that function?

While waiting for a response from @fedekunze, I've removed the automerge label. If that function is here to stay, I'd like to see a test case for it - I can write one this time, no probs.

[codecov]

Codecov Report

Merging #5779 into master will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5779      +/-   ##
==========================================
+ Coverage   35.91%   36.07%   +0.16%     
==========================================
  Files         341      341              
  Lines       34745    34731      -14     
==========================================
+ Hits        12478    12530      +52     
+ Misses      21023    20955      -68     
- Partials     1244     1246       +2

Impacted Files	Coverage Δ
types/rest/rest.go	86.33% <ø> (+32.53%)	⬆️

[alessio]

Nevermind, I've reintroduced the function for now (and written a test case)