client: rename CLIContext to Context #6290

sahith-narahari · 2020-05-27T18:21:13Z

Description

closes: #3061

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

x/upgrade/module.go

anilcse

Added a few comments, otherwise lgtm

client/context_test.go

client/lcd/root.go

…actor-cli-ctx

codecov · 2020-05-27T19:21:41Z

Codecov Report

Merging #6290 into master will increase coverage by 0.00%.
The diff coverage is 10.29%.

@@           Coverage Diff           @@
##           master    #6290   +/-   ##
=======================================
  Coverage   55.70%   55.70%           
=======================================
  Files         447      446    -1     
  Lines       26933    26931    -2     
=======================================
  Hits        15003    15003           
+ Misses      10859    10857    -2     
  Partials     1071     1071

alexanderbez

ACK

jackzampolin · 2020-05-27T20:01:26Z

There's a lot of other stuff I would want to see in a PR titled "Refactor CLIContext..." but this is a good start. Will be an annoying change for app devs. We should add a note for users migrating

aaronc

Please add a CHANGELOG entry @sahith-narahari

client/lcd/root.go

CHANGELOG.md

client/routes.go

client/rpc/routes.go

fedekunze

LGTM

alessio · 2020-05-29T14:07:56Z

alessio@bangalter:~/work/cosmos-sdk$ git log --oneline -n 1
3324981ac (HEAD -> sahith/refactor-cli-ctx, origin/sahith/refactor-cli-ctx) Apply suggestions from code review
alessio@bangalter:~/work/cosmos-sdk$ make mocks
mockgen -source=client/context/account_retriever.go -package mocks -destination tests/mocks/account_retriever.go
2020/05/29 16:07:42 Loading input failed: loading package failed
Makefile:39: recipe for target 'mocks' failed
make: *** [mocks] Error 1

sahith-narahari · 2020-05-29T14:25:44Z

@alessio I'm working on updating docs and ADRs currently, will update once it's done

…k into sahith/refactor-cli-ctx

alessio · 2020-05-29T14:39:17Z

docs need a little bit more work too:

alessio@bangalter:~/work/cosmos-sdk$ grep -rwl CLIContext docs/
docs/building-modules/module-interfaces.md
docs/architecture/adr-020-protobuf-transaction-encoding.md
docs/architecture/adr-021-protobuf-query-encoding.md
docs/interfaces/query-lifecycle.md

EDIT: I've just read your message (I'm working on updating docs and ADRs currently, will update once it's done) - good one!

make mocks works again now too, thanks!

sahith-narahari · 2020-05-29T14:54:32Z

Yes, few docs and ADRs are still pending. I'll resume after our call

…k into sahith/refactor-cli-ctx

alessio

ACK

CHANGELOG change was introduced. Hence dismissing

* Refactor CliContext as Context * Fix lint issues * Fix goimports * Fix gov tests * Resolved ci-lint issues * Add changelog * Rename cliCtx to clientCtx * Fix mocks and routes * Add changelog * Update changelog * Apply suggestions from code review Co-authored-by: Alessio Treglia <alessio@tendermint.com> * merge client/rpc/ro{ot,utes}.go * Update docs * client/rpc: remove redundant client/rpc.RegisterRPCRoutes * regenerate mocks * Update ADRs Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Refactor CliContext as Context

36534f0

sahith-narahari mentioned this pull request May 27, 2020

Refactor CliContext to use as client.Context #6225

Closed

Fix lint issues

f59741e

anilcse reviewed May 27, 2020

View reviewed changes

x/upgrade/module.go Outdated Show resolved Hide resolved

anilcse reviewed May 27, 2020

View reviewed changes

client/context_test.go Show resolved Hide resolved

client/lcd/root.go Outdated Show resolved Hide resolved

sahith-narahari added 5 commits May 28, 2020 00:19

Fix goimports

64f7227

Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/ref…

c5dc178

…actor-cli-ctx

Fix gov tests

4c7c91c

Resolved ci-lint issues

42754e5

Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/ref…

29717fa

…actor-cli-ctx

sahith-narahari marked this pull request as ready for review May 27, 2020 19:29

sahith-narahari requested review from aaronc, alessio, alexanderbez, clevinson, fedekunze and jgimeno as code owners May 27, 2020 19:29

alexanderbez approved these changes May 27, 2020

View reviewed changes

alexanderbez added the R4R label May 27, 2020

jackzampolin approved these changes May 27, 2020

View reviewed changes

aaronc added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label May 27, 2020

aaronc previously requested changes May 27, 2020

View reviewed changes

Add changelog

3158bcd

fedekunze suggested changes May 27, 2020

View reviewed changes

client/lcd/root.go Outdated Show resolved Hide resolved

Merge branch 'master' into sahith/refactor-cli-ctx

89af179

alessio reviewed May 28, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

alessio reviewed May 28, 2020

View reviewed changes

client/routes.go Show resolved Hide resolved

alessio reviewed May 28, 2020

View reviewed changes

client/rpc/routes.go Show resolved Hide resolved

fedekunze approved these changes May 29, 2020

View reviewed changes

Alessio Treglia and others added 3 commits May 29, 2020 16:10

Merge branch 'master' into sahith/refactor-cli-ctx

e9100a5

merge client/rpc/ro{ot,utes}.go

f67895a

Update docs

ca2698a

sahith-narahari and others added 2 commits May 29, 2020 19:57

Merge branch 'sahith/refactor-cli-ctx' of github.com:cosmos/cosmos-sd…

5d0ecd4

…k into sahith/refactor-cli-ctx

client/rpc: remove redundant client/rpc.RegisterRPCRoutes

d0d8624

regenerate mocks

21ee9e5

sahith-narahari added 2 commits May 30, 2020 12:30

Update ADRs

dfd8688

Merge branch 'sahith/refactor-cli-ctx' of github.com:cosmos/cosmos-sd…

e74b39a

…k into sahith/refactor-cli-ctx

sahith-narahari requested a review from alessio May 30, 2020 16:57

fedekunze requested a review from aaronc May 31, 2020 01:21

fedekunze changed the title ~~Refactor CliContext as Context~~ context: rename CliContext to Context May 31, 2020

fedekunze changed the title ~~context: rename CliContext to Context~~ client: rename CliContext to Context May 31, 2020

fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label May 31, 2020

Merge branch 'master' into sahith/refactor-cli-ctx

81fb833

alessio approved these changes Jun 1, 2020

View reviewed changes

mergify bot merged commit 39f53ac into master Jun 1, 2020

mergify bot deleted the sahith/refactor-cli-ctx branch June 1, 2020 12:46

aaronc mentioned this pull request Jun 3, 2020

Change GetQueryCmd to take client.Context #6326

Merged

8 tasks

clevinson added this to the v0.39 milestone Jun 11, 2020

alessio changed the title ~~client: rename CliContext to Context~~ client: rename CLIContext to Context Oct 1, 2020

ilyabukalov added a commit to Sifchain/sifnode that referenced this pull request Nov 11, 2020

client package refactoring cosmos/cosmos-sdk#6290

8f85488

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

client: rename CLIContext to Context #6290

client: rename CLIContext to Context #6290

sahith-narahari commented May 27, 2020 •

edited

Loading

anilcse left a comment

codecov bot commented May 27, 2020 •

edited

Loading

alexanderbez left a comment

jackzampolin commented May 27, 2020

aaronc left a comment

fedekunze left a comment

alessio commented May 29, 2020

sahith-narahari commented May 29, 2020

alessio commented May 29, 2020 •

edited

Loading

sahith-narahari commented May 29, 2020

alessio left a comment

client: rename CLIContext to Context #6290

client: rename CLIContext to Context #6290

Conversation

sahith-narahari commented May 27, 2020 • edited Loading

Description

anilcse left a comment

Choose a reason for hiding this comment

codecov bot commented May 27, 2020 • edited Loading

Codecov Report

alexanderbez left a comment

Choose a reason for hiding this comment

jackzampolin commented May 27, 2020

aaronc left a comment

Choose a reason for hiding this comment

fedekunze left a comment

Choose a reason for hiding this comment

alessio commented May 29, 2020

sahith-narahari commented May 29, 2020

alessio commented May 29, 2020 • edited Loading

sahith-narahari commented May 29, 2020

alessio left a comment

Choose a reason for hiding this comment

sahith-narahari commented May 27, 2020 •

edited

Loading

codecov bot commented May 27, 2020 •

edited

Loading

alessio commented May 29, 2020 •

edited

Loading