Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review followup of #6374 #6430

Merged
merged 2 commits into from
Jun 13, 2020
Merged

Review followup of #6374 #6430

merged 2 commits into from
Jun 13, 2020

Conversation

AdityaSripal
Copy link
Member

Description

Addresses comments from @fedekunze on #6374

#6374 (review)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@AdityaSripal AdityaSripal added T: Tests R4R A:automerge Automatically merge PR once all prerequisites pass. labels Jun 12, 2020
@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #6430 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6430      +/-   ##
==========================================
+ Coverage   55.67%   55.72%   +0.04%     
==========================================
  Files         465      465              
  Lines       27782    27782              
==========================================
+ Hits        15469    15481      +12     
+ Misses      11206    11197       -9     
+ Partials     1107     1104       -3     

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit e07c1e2 into master Jun 13, 2020
@mergify mergify bot deleted the 6374-followup branch June 13, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants