Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR 029: Fee Grant Module #7106

Merged
merged 10 commits into from
Oct 9, 2020
Merged

ADR 029: Fee Grant Module #7106

merged 10 commits into from
Oct 9, 2020

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Aug 19, 2020

In preparation for post-Stargate work, feel free to ignore until after we cut an RC.

ref: #7074


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@aaronc aaronc mentioned this pull request Aug 19, 2020
4 tasks
@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #7106 into master will decrease coverage by 1.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7106      +/-   ##
==========================================
- Coverage   56.02%   54.61%   -1.41%     
==========================================
  Files         591      547      -44     
  Lines       37177    37132      -45     
==========================================
- Hits        20827    20280     -547     
- Misses      14232    15194     +962     
+ Partials     2118     1658     -460     

@aaronc aaronc marked this pull request as ready for review August 20, 2020 14:12
@aaronc aaronc added this to the v0.41 milestone Aug 20, 2020
@aaronc aaronc added the T: ADR An issue or PR relating to an architectural decision record label Aug 21, 2020
@aaronc aaronc mentioned this pull request Sep 30, 2020
9 tasks
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Contributor

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, otherwise LGTM!

docs/architecture/adr-029-fee-grant-module.md Outdated Show resolved Hide resolved
docs/architecture/adr-029-fee-grant-module.md Outdated Show resolved Hide resolved
@aaronc
Copy link
Member Author

aaronc commented Oct 7, 2020

Could one of you take a quick look @alexanderbez @alessio ? Would be good to get an ACK from outside our team before merging this in. (At least that's my general sense for how we're approaching ADRs)

@aaronc
Copy link
Member Author

aaronc commented Oct 9, 2020

I'm going to go ahead and merge this. If people have follow-up comments that didn't get addressed here we can discuss in separate PRs.

@aaronc aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 9, 2020
@mergify mergify bot merged commit 90579c0 into master Oct 9, 2020
@mergify mergify bot deleted the aaronc/adr-fee-grant branch October 9, 2020 15:09
@atheeshp atheeshp mentioned this pull request Dec 2, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/feegrant T: ADR An issue or PR relating to an architectural decision record
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants