Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robert/docs slashing #8329

Merged
merged 9 commits into from
Jan 15, 2021
Merged

Robert/docs slashing #8329

merged 9 commits into from
Jan 15, 2021

Conversation

robert-zaremba
Copy link
Collaborator

Description

x/slashing docs general audit & cleanup

closes: #8070


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@amaury1093 amaury1093 added backport/0.40.x (Stargate) T:Docs Changes and features related to documentation. labels Jan 15, 2021
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

x/slashing/spec/02_state.md Outdated Show resolved Hide resolved
x/slashing/spec/02_state.md Outdated Show resolved Hide resolved
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few comments. Looks good otherwise

robert-zaremba and others added 3 commits January 15, 2021 15:04
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
@robert-zaremba robert-zaremba merged commit d39c42c into master Jan 15, 2021
@robert-zaremba robert-zaremba deleted the robert/docs-slashing branch January 15, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module Docs Updates: x/slashing
3 participants