Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: commit the ndb in LoadVersionForOverwriting #640

Merged
merged 3 commits into from
Dec 6, 2022
Merged

fix: commit the ndb in LoadVersionForOverwriting #640

merged 3 commits into from
Dec 6, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Dec 4, 2022 •
edited
Loading

need to backport to 0.19.x.
It was previously included in #636, separate out for easier review.

@yihuang yihuang requested a review from a team as a code owner December 4, 2022 04:01
yihuang
yihuang commented Dec 4, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@tac0turtle
Copy link
Member

was this a regression or a new change?

@yihuang
Copy link
Collaborator Author

yihuang commented Dec 6, 2022

was this a regression or a new change?

it's a bug fix I believe.

yihuang
yihuang commented Dec 6, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@tac0turtle
Copy link
Member

should we backport this to 0.19?

@yihuang
Copy link
Collaborator Author

yihuang commented Dec 6, 2022

should we backport this to 0.19?

I think so

@tac0turtle tac0turtle merged commit e144f08 into cosmos:master Dec 6, 2022
@tac0turtle
Copy link
Member

amazing I will test on a chain before final release

@tac0turtle
Copy link
Member

@Mergifyio backport release/v0.19.x

mergify bot pushed a commit that referenced this pull request Dec 7, 2022
@yihuang @mergify
fix: commit the ndb in LoadVersionForOverwriting (#640)
cfaebd0 
(cherry picked from commit e144f08)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Dec 7, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Dec 7, 2022

backport release/v0.19.x

✅ Backports have been created

@yihuang yihuang deleted the commit-rollback branch December 7, 2022 09:51
tac0turtle added a commit that referenced this pull request Dec 7, 2022
@mergify @yihuang @tac0turtle
fix: commit the ndb in LoadVersionForOverwriting (backport #640) (#643)
43560dc 
Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
@yihuang yihuang mentioned this pull request Feb 1, 2023
Merged
13 tasks
ankurdotb pushed a commit to cheqd/iavl that referenced this pull request Feb 28, 2023
@mergify @yihuang
@tac0turtle @ankurdotb
fix: commit the ndb in LoadVersionForOverwriting (backport cosmos#640) (
35ef923 
cosmos#643)

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
@coderabbitai coderabbitai bot mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cool-develope cool-develope cool-develope approved these changes

Assignees

@alexanderbez alexanderbez

@facundomedica facundomedica

@tac0turtle tac0turtle

@cool-develope cool-develope

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yihuang @tac0turtle @cool-develope @alexanderbez @facundomedica