Fix open handles in tests and update testing tools #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zatteo
commented
Nov 22, 2023
•
zatteo
commented
- Fix open handles in tests so that there are no more 1xx lines to scroll before seeing what went wrong in tests
- Update testing tools
- Fix issues coming from the testing tools update
Crash--
approved these changes
Dec 5, 2023
zatteo
force-pushed
the
test/fix-open-handles
branch
from
bb65472
to
86cd8e9
Compare
Following @testing-library/react-native package update, I got a "Trying to detect host component names triggered the following error" error in useCookieResyncOnResume test. I updated how we mock react-native with the recommended guidelines. See https://callstack.github.io/react-native-testing-library/docs/troubleshooting#mocking-react-native
We have a lot of open handles flooding the end of our test results. It seems that they are due to a React issue fixed in 18+. Dan Abramov wrote a small package to fix the issue temporarly. I added it here manually because it has an error in the semver version check. This code should be removed when upgrading React to 18+. facebook/react#20756 (comment)
There are useless warnings coming from the update of @testing-library/react-native linked to the Switch component and dispatchCommand. They are removed in React Native 0.72. This is a temporary mock to keep our tests clean. callstack/react-native-testing-library#1422
zatteo
force-pushed
the
test/fix-open-handles
branch
from
86cd8e9
to
ceaeab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.