fix: Load ClouderyViewSwitch's WebViews sequentially #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous implementation, both Signing and Login WebViews were loaded in parallel When doing this, there was a race condition on the Cloudery that would create two new sessions in parallel and so two different cookies instead on a single one Later in the process, this would occasionally produce some CSRF issues due two the co-existence of two cookies, resulting in a 422 error from the Cloudery To prevent that, we want both WebViews to be loaded sequentially to ensure only the first WebView will create a new session on Cloudery This should be a bit slower, but this is acceptable
Ldoppea
force-pushed
the
fix/csrf_race_condition
branch
from
d83f6cf
to
efe4438
Compare
Crash--
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous implementation, both Signing and Login WebViews were loaded in parallel
When doing this, there was a race condition on the Cloudery that would create two new sessions in parallel and so two different cookies instead on a single one
Later in the process, this would occasionally produce some CSRF issues due two the co-existence of two cookies, resulting in a 422 error from the Cloudery
To prevent that, we want both WebViews to be loaded sequentially to ensure only the first WebView will create a new session on Cloudery
This should be a bit slower, but this is acceptable