Use DI for cookie config #12699
Closed
Use DI for cookie config #12699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkelty
requested review from
brandonkelly
and removed request for
benjamindavid
timkelty
commented
Feb 18, 2023
| \yii\web\Cookie::class => \Craft::cookieConfig() | ||
| ]); | ||
| } | ||
|
|
There was a problem hiding this comment.
So it can be shared between app and test bootstraps.
| foreach ($cookieConfig as $property => $value) { | ||
| $this->assertEquals($cookie->$property, $value); | ||
| } | ||
| } |
There was a problem hiding this comment.
I have no idea where this test should go…so I put it here for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring the passing around of a common cookie config, we should use Yii's DI container to load our cookie config anywhere
\yii\web\Cookieis instantiated.Related: craftcms/commerce#3091