-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Set shipping costs to zero" in discounts should set the base shipping cost to 0. #561
Comments
@outline4 the "Set shipping costs to zero for matching products" does not set base shipping cost to zero as the checkbox label clarifies. Are you looking for a checkbox option that makes the whole shipping cost free? |
That’s exactly what I am looking for...
… Am 12.11.2018 um 08:08 schrieb Luke Holder ***@***.***>:
@outline4 <https://github.com/outline4> the "Set shipping costs to zero for matching products" does not set base shipping cost to zero as the checkbox implies. Are you looking for a checkbox that makes the whole shipping cost free?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#561 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAI5pIOl5g_rOfibwMVFB7bkD8fdNM4cks5uuR5xgaJpZM4YYhos>.
|
If it's any help at all, I can confirm that in Craft Commerce 1 the same checkbox did set base shipping costs to zero. By the sound of this it seems like that was intentional, but it definitely would be nice to have the same option provided by Commerce 1. |
@lukeholder @andris-sevcenko Any chance this will be fixed soon? I need this for my client, which relies a lot on giving a Free Shipping coupon code. |
If no conditions are set (then all product are matching the conditions), the expected behavior is indeed a free shipping on the whole order. If its no there, a Free Shipping Coupon is a must! |
Free shipping is our top coupon need! |
Also, semi-related is #699 |
This feature will be out soon in 2.1 |
@lukeholder Thanks Luke! That's gonna be very helpful. Please make sure to look at #699 too to be sure the bug doesn't create issues there too. Let me know if you'd like me to grab a dev copy and test the features. |
Hi, there. I wanted to comment here first before creating a new issue to see if the fix that will be out in 2.1 will address an issue I'm facing. Let me know what you think. Our client chose to go with a tiered shipping paradigm based on the order total. We're using the Maximum Order Total Price condition along with the Base Rate field to set cost. It appears that when order-based rules are applied, the free shipping options on the product and discount level do not work at all. I've tested this by switching to item-based shipping rules and in that case, the free shipping options do work as expected. What I would expect is for a product with free shipping to be removed from the order total used to calculate the order-based shipping rules. Similarly, I would expect any products matched in a free shipping discount to be removed from the order total used to calculate the shipping rules. As of right now, there are free shipping options for products and discounts that do nothing when using order-based shipping rules. Is that intentional? If not, would you like me to create a separate issue or is it related to what you've addressed here? |
@RandomJo I have just pushed some changes on the develop branch. This adds order level shipping discounts (whole order shipping free) and improves the item level free shipping discounts to work more like the free shipping flag on the products themselves. They will be in the next release. The changes also improves the logic for free shipping items with a max shipping rate. Please note that on the latest 2.0.x we renamed Please try the develop branch or wait for the next release and let me know if you are still not getting the results you are looking for. Thanks |
That is fantastic. Thank you so much! |
Hey, Luke. I tested this out in the develop branch, and the new discount option works well—just as expected. However, the free shipping checkbox on the product doesn't work like I was anticipating. I have a tiered base rate for shipping based on the Maximum Order Total Value and Minimum Order Total Value fields. But, when I mark free shipping on a product, it is not removed from that calculation. The base rate for shipping still applies even when I have one item in the cart that is marked for free shipping. I also tried setting a minimum value of $0.01 on the lower shipping tier to see if that made a difference and it didn't. Should I expect the free shipping checkbox to do anything in this scenario, or did I misunderstand the change you made? |
Description
In a discount, when choosing "Set shipping costs to zero for matching products" it should set all shipping costs to 0. Especially true for "Base" shipping costs.
Additional info
The text was updated successfully, but these errors were encountered: