Detailed permissions #1869
Closed
Detailed permissions #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssions for each product type. - Created \craft\commerce\services\Products::hasPermission method that deny or allow user production permission with ProductPermissionTest unit test.
Implement hasPermission on edit, delete and save production action methods
Added create product permission in action edit product page
…es::getEditableProductTypeIds method Removed commerce nav Products manage product permission condition.
… permission. - Created ProductTypes::getCreatableProductTypes that gets only products based on permission. - Added delete, create and edit permission on Product element defineActions.
…e permission including their stat queries.
Added create product permission on action save product
… type permission to detailed product type edit, create and delete products permission.
pdaleramirez
requested review from
nfourtythree
and removed request for
nfourtythree
…raftcms/commerce into feature/edit-delete-product-permission
Added canCreateProduct and canDeleteProduct twig variable permission on edit product page.
Codecov Report
@@ Coverage Diff @@
## 4.0 #1869 +/- ##
======================================
Coverage ? 16.27%
Complexity ? 5577
======================================
Files ? 273
Lines ? 18147
Branches ? 0
======================================
Hits ? 2954
Misses ? 15193
Partials ? 0 Continue to review full report at Codecov.
|
lukeholder
approved these changes
Dec 1, 2020
|
Will resolve #174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split Manage Promotions
Split Manage Subscriptions
Split Manage Customer
Split Manage Orders
Keep Shipping and Tax as is.
Keep Manage Store as is.