Adding feature-flags to release configuration #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Could you please also update README for new options? |
This PR adds `features` and `all_features` as both flags to the CLI as well as the `release.toml` configuration. This change allows you to tell `cargo-release` to verify the package with certain features enabled, in order to avoid needing to use `no-verify` for crates that depend on certain features being enabled (or simply any feature) before they can be uploaded. This change is dependent on rust-lang/cargo#6453, which adds this feature to the base `cargo publish` command. The motivation behind this PR is the same as the above mentioned cargo PR: reducing the amount of packaging errors that can happen due to people not being able to verify their code because it has some feature requirements for compilation, ultimately resulting in a more healthy package ecosystem.
spacekookie
force-pushed
the
publish-featured
branch
from
38a6369
to
b1e3e1f
Compare
|
ping @sunng87: Hey there, apologies for the long wait! I added the docs to |
sunng87
approved these changes
Jan 29, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
featuresandall_featuresas both flags to the CLIas well as the
release.tomlconfiguration. This change allows youto tell
cargo-releaseto verify the package with certain featuresenabled, in order to avoid needing to use
no-verifyfor cratesthat depend on certain features being enabled (or simply any
feature) before they can be uploaded.
This change is dependent on rust-lang/cargo#6453, which adds this
feature to the base
cargo publishcommand.The motivation behind this PR is the same as the above mentioned
cargo PR: reducing the amount of packaging errors that can happen
due to people not being able to verify their code because it has
some feature requirements for compilation, ultimately resulting in
a more healthy package ecosystem.